Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Moving Preview Anomaly Detectors to Transport layer #321

Merged
merged 6 commits into from
Jan 6, 2021

Conversation

saratvemulapalli
Copy link
Contributor

*Issue #195 *

Description of changes:
Moving Preview API to transport layer

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #321 (bcf1b51) into master (21418a4) will increase coverage by 0.70%.
The diff coverage is 69.17%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #321      +/-   ##
============================================
+ Coverage     76.58%   77.28%   +0.70%     
- Complexity     2242     2277      +35     
============================================
  Files           209      214       +5     
  Lines         10173    10242      +69     
  Branches        905      909       +4     
============================================
+ Hits           7791     7916     +125     
+ Misses         1968     1908      -60     
- Partials        414      418       +4     
Flag Coverage Δ Complexity Δ
cli 79.27% <ø> (ø) 0.00 <ø> (ø)
plugin 77.13% <69.17%> (+0.75%) 0.00 <29.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...arch/ad/rest/RestPreviewAnomalyDetectorAction.java 15.78% <15.78%> (ø) 4.00 <4.00> (?)
...arch/ad/rest/RestExecuteAnomalyDetectorAction.java 22.50% <16.66%> (+10.68%) 3.00 <0.00> (ø)
...ansport/PreviewAnomalyDetectorTransportAction.java 86.88% <86.88%> (ø) 11.00 <11.00> (?)
...stroforelasticsearch/ad/AnomalyDetectorPlugin.java 95.08% <100.00%> (+0.04%) 11.00 <0.00> (ø)
...rch/ad/transport/PreviewAnomalyDetectorAction.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...ch/ad/transport/PreviewAnomalyDetectorRequest.java 100.00% <100.00%> (ø) 8.00 <8.00> (?)
...h/ad/transport/PreviewAnomalyDetectorResponse.java 100.00% <100.00%> (ø) 4.00 <4.00> (?)
...arch/ad/transport/ADStatsNodesTransportAction.java 94.44% <0.00%> (-5.56%) 8.00% <0.00%> (-1.00%)
...port/SearchAnomalyDetectorInfoTransportAction.java 59.09% <0.00%> (-4.55%) 4.00% <0.00%> (ø%)
...asticsearch/ad/cluster/ADClusterEventListener.java 88.00% <0.00%> (-2.00%) 13.00% <0.00%> (-1.00%)
... and 8 more

build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
@saratvemulapalli saratvemulapalli added the enhancement New feature or request label Dec 9, 2020
Copy link
Member

@kaituo kaituo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. I know it is not easy.

@saratvemulapalli
Copy link
Contributor Author

Thanks for the change. I know it is not easy.

No problem, its definitely worth it : )

@saratvemulapalli saratvemulapalli merged commit dfca231 into master Jan 6, 2021
@saratvemulapalli saratvemulapalli deleted the preview-api branch January 6, 2021 01:54
ylwu-amzn pushed a commit that referenced this pull request Feb 24, 2021
* Moving Preview Anomaly Detectors to Transport layer

* Removing powermock for tests

* Adding tests for Preview Transport Action

* Adding test coverage for Preview Transport Action
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants