This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Wrongly updating all three variants of rca.conf with the current one. #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we update the rca.conf with the new set of muted rcas/deciders/actions, the idea is to pick each of rca.conf, rca_master.conf and rca_idle_master.conf and update each of them with the latest set of muted *, keeping everything else constant. The code before this would have made all files exactly alike.
sidheart
previously approved these changes
Sep 10, 2020
rguo-aws
previously approved these changes
Sep 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
============================================
+ Coverage 69.60% 70.11% +0.51%
- Complexity 2397 2481 +84
============================================
Files 321 322 +1
Lines 14311 14571 +260
Branches 1189 1227 +38
============================================
+ Hits 9961 10217 +256
- Misses 3977 3990 +13
+ Partials 373 364 -9 Continue to review full report at Codecov.
|
sidheart
approved these changes
Sep 10, 2020
sruti1312
approved these changes
Sep 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #: #421
Description of changes:
When we update the rca.conf with the new set of muted rcas/deciders/actions, the idea
is to pick each of rca.conf, rca_master.conf and rca_idle_master.conf
and update each of them with the latest set of muted *, keeping everything
else constant. The code before this would have made all files exactly alike.
Tests:
Ignoring the tests in this class. They will be later enabled as part of #422
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.