This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Decision policy for consolidating actions #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidheart
approved these changes
Oct 1, 2020
rguo-aws
approved these changes
Oct 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #440 +/- ##
============================================
+ Coverage 72.02% 72.06% +0.04%
- Complexity 2606 2607 +1
============================================
Files 325 325
Lines 14682 14686 +4
Branches 1229 1229
============================================
+ Hits 10574 10583 +9
+ Misses 3711 3705 -6
- Partials 397 398 +1
Continue to review full report at Codecov.
|
|
Created #442 to track test coverage |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #: #441
Description of changes:
Decision Policies provide an abstraction to simplify complicated decider logic. A policy evaluates a subset of conditions within a decider. The decider can then consolidate actions suggested by each and add extra conditionals on top of them.
This PR adds the
DecisionPolicyinterface and implements its use in theHeapHealthDecider.Tests:
Should be tested by the
OldGenDecisionPolicytests.If new tests are added, how long do the new ones take to complete
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.