This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityaj1107
requested review from
yojs and
ktkrg
and removed request for
yojs
November 10, 2020 01:56
adityaj1107
force-pushed
the
enable-temperature-profile
branch
2 times, most recently
from
November 12, 2020 04:32
8b55deb
to
50ee030
Compare
can we make sure that the temperature profile is working with the new perftop dashboard we added for it ? |
yojs
previously approved these changes
Nov 18, 2020
Comment on lines
+65
to
+66
// Mean Temperature is a mean of the normalized heat of the resource used across shards on the node. | ||
// e.g. if there are 10 shards on the node and the normalized sum of the resource used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome ! great comment
// Mean Temperature is a mean of the normalized heat of the resource used across shards on the node. | ||
// e.g. if there are 10 shards on the node and the normalized sum of the resource used | ||
// across shards is 33. The mean would be 3.3 | ||
// This aim is the balance this parameter across the nodes and have as little delta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: this -> the ?
.../opendistro/elasticsearch/performanceanalyzer/rca/framework/core/temperature/ShardStore.java
Show resolved
Hide resolved
...com/amazon/opendistro/elasticsearch/performanceanalyzer/rca/persistence/SQLitePersistor.java
Show resolved
Hide resolved
yujias0706
force-pushed
the
enable-temperature-profile
branch
from
February 9, 2021 22:34
3c1ce26
to
0fe14db
Compare
khushbr
approved these changes
Feb 9, 2021
...com/amazon/opendistro/elasticsearch/performanceanalyzer/rca/persistence/SQLitePersistor.java
Show resolved
Hide resolved
yojs
approved these changes
Feb 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #: Enable Node Temperature RCA. This PR enables the Node Temperature RCA on the cluster.
Description of changes: This commit enables the temperature Profile and refactors the code which removes the healthy/unhealthy context of the dimensional RCAs. Also adds comments and checks for values of Flow Units in the Individual RCAs & Group RCAs. Also change the use to ShardIndexKey instead of Shard ID and Index ID separately.
Tests: Tested on Docker. Sample Output:
Node 1:
Node 2:
AllTemperatureDimensions
have also been enabled.If new tests are added, how long do the new ones take to complete
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.