Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Enable temperature profile #512

Merged
merged 7 commits into from
Feb 10, 2021
Merged

Enable temperature profile #512

merged 7 commits into from
Feb 10, 2021

Conversation

adityaj1107
Copy link
Contributor

@adityaj1107 adityaj1107 commented Nov 10, 2020

Fixes #: Enable Node Temperature RCA. This PR enables the Node Temperature RCA on the cluster.

Description of changes: This commit enables the temperature Profile and refactors the code which removes the healthy/unhealthy context of the dimensional RCAs. Also adds comments and checks for values of Flow Units in the Individual RCAs & Group RCAs. Also change the use to ShardIndexKey instead of Shard ID and Index ID separately.

Tests: Tested on Docker. Sample Output:

Node 1:

[root@391ae37d34b6 tmp]# curl --url "localhost:9600/_opendistro/_performanceanalyzer/rca?name=NodeTemperatureRca&local=true" -XGET | python -m json.tool 
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   459  100   459    0     0   2244      0 --:--:-- --:--:-- --:--:--  2250
{
    "NodeTemperatureRca": [
        {
            "CompactNodeSummary": [
                {
                    "CPU_Utilization_mean": 0,
                    "CPU_Utilization_num_shards": 0,
                    "CPU_Utilization_total": 0.0,
                    "Heap_AllocRate_mean": 0,
                    "Heap_AllocRate_num_shards": 0,
                    "Heap_AllocRate_total": 0.0,
                    "Shard_Size_In_Bytes_mean": 3,
                    "Shard_Size_In_Bytes_num_shards": 3,
                    "Shard_Size_In_Bytes_total": 23449682.0,
                    "host_address": "172.29.0.2",
                    "node_id": "SqlWFl9BR02Bz0gVcFS8qQ"
                }
            ],
            "rca_name": "NodeTemperatureRca",
            "state": "unknown",
            "timestamp": 1605582526245
        }
    ]
}

Node 2:

[root@ef8562eeb2ed tmp]# curl --url "localhost:9600/_opendistro/_performanceanalyzer/rca?name=NodeTemperatureRca&local=true" -XGET | python -m json.tool 
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   459  100   459    0     0   9945      0 --:--:-- --:--:-- --:--:-- 10200
{
    "NodeTemperatureRca": [
        {
            "CompactNodeSummary": [
                {
                    "CPU_Utilization_mean": 0,
                    "CPU_Utilization_num_shards": 0,
                    "CPU_Utilization_total": 0.0,
                    "Heap_AllocRate_mean": 0,
                    "Heap_AllocRate_num_shards": 0,
                    "Heap_AllocRate_total": 0.0,
                    "Shard_Size_In_Bytes_mean": 5,
                    "Shard_Size_In_Bytes_num_shards": 2,
                    "Shard_Size_In_Bytes_total": 15918349.0,
                    "host_address": "172.29.0.3",
                    "node_id": "XyinFukETiaOdwfSkGnM8w"
                }
            ],
            "rca_name": "NodeTemperatureRca",
            "state": "unknown",
            "timestamp": 1605582517354
        }
    ]
}

AllTemperatureDimensions have also been enabled.

If new tests are added, how long do the new ones take to complete

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@adityaj1107 adityaj1107 requested review from yojs and ktkrg and removed request for yojs November 10, 2020 01:56
@adityaj1107 adityaj1107 marked this pull request as draft November 10, 2020 04:54
@adityaj1107 adityaj1107 force-pushed the enable-temperature-profile branch 2 times, most recently from 8b55deb to 50ee030 Compare November 12, 2020 04:32
@adityaj1107 adityaj1107 marked this pull request as ready for review November 17, 2020 03:25
@yojs
Copy link
Contributor

yojs commented Nov 18, 2020

can we make sure that the temperature profile is working with the new perftop dashboard we added for it ?

yojs
yojs previously approved these changes Nov 18, 2020
Comment on lines +65 to +66
// Mean Temperature is a mean of the normalized heat of the resource used across shards on the node.
// e.g. if there are 10 shards on the node and the normalized sum of the resource used
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ! great comment

// Mean Temperature is a mean of the normalized heat of the resource used across shards on the node.
// e.g. if there are 10 shards on the node and the normalized sum of the resource used
// across shards is 33. The mean would be 3.3
// This aim is the balance this parameter across the nodes and have as little delta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: this -> the ?

@yojs yojs self-requested a review November 18, 2020 18:32
Base automatically changed from master to main February 8, 2021 19:21
@khushbr khushbr removed the request for review from sidheart February 9, 2021 19:25
@khushbr khushbr removed the request for review from ktkrg February 10, 2021 01:47
@khushbr khushbr merged commit b167300 into main Feb 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants