Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Changed master total PendingQueueSize to PendingQueueSize per task type #552

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Changed master total PendingQueueSize to PendingQueueSize per task type #552

wants to merge 2 commits into from

Conversation

meetshah777
Copy link
Contributor

@meetshah777 meetshah777 commented Jan 25, 2021 •
edited
Loading

Master Pending Queue size per task type

Earlier we were publishing Total number of pending task. For RCA analysis Pending Queue size per task type will give better understanding. Changed total Queue Size to Queue size per task type

Tests:

Added some manual entry. Below are the output of manual entry

  1. Table of Master_PendingQueueSize
sqlite> select * from Master_PendingQueueSize;
create-index|5.0|5.0|5.0|5.0
delete-index|3.0|3.0|3.0|3.0
shard-started|10.0|10.0|10.0|10.0
  1. Schema of PendingQueueSize
sqlite> .schema Master_PendingQueueSize
CREATE TABLE Master_PendingQueueSize(Master_PendingTaskType varchar null, sum double null, avg double null, min double null, max double null);

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Base automatically changed from master to main February 8, 2021 19:21
amathur1893
amathur1893 suggested changes Mar 19, 2021
View reviewed changes
.../amazon/opendistro/elasticsearch/performanceanalyzer/reader/ReaderMetricsProcessorTests.java
assertEquals(2.2d, pending, 0.001);
assertEquals(1.0d,pending,0.001);
pending = Double.parseDouble(res.get(1).get(valueField).toString());
assertEquals(3.0d, pending, 0.001);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests to assert pending task type as well

.../amazon/opendistro/elasticsearch/performanceanalyzer/reader/ReaderMetricsProcessorTests.java
for (int i = 0; i < row0.size(); i++) {
Double pending = Double.parseDouble(row0.get(i).toString());
assertEquals(2.2d, pending, 0.001);
row = res.get(1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amathur1893 amathur1893 amathur1893 requested changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meetshah777 @amathur1893