Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Removed stack trace when catches anonymizing data error #1014

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

chloe-zh
Copy link
Member

Issue #, if available:
#1004 #431

Description of changes:
Removed the stack trace for query data anonymizing error since it causes confusion for users who execute metadata queries and dml queries. Now it only prints a warning in log with error message "Caught an exception when anonymizing sensitive data" as follows:

Giving query show tables like '%'

[2021-01-27T14:31:29,304][WARN ][c.a.o.s.l.u.QueryDataAnonymizer] [147dda5ddf8a.ant.amazon.com] Caught an exception when anonymizing sensitive data
[2021-01-27T14:31:29,305][INFO ][c.a.o.s.l.p.RestSqlAction] [147dda5ddf8a.ant.amazon.com] [a8a76a90-8b90-449e-b50c-44cd954ee851] Incoming request /_opendistro/_sql?pretty=true: 
  show tables like '%'

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #1014 (7b4562e) into develop (5c19cca) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1014   +/-   ##
==========================================
  Coverage      99.87%   99.87%           
  Complexity      2406     2406           
==========================================
  Files            234      234           
  Lines           5526     5526           
  Branches         357      357           
==========================================
  Hits            5519     5519           
  Misses             5        5           
  Partials           2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c19cca...7b4562e. Read the comment docs.

Copy link
Member

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@chloe-zh chloe-zh merged commit df61641 into opendistro-for-elasticsearch:develop Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants