This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Version Upgrade for ODFE 1.13 Release #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcui1225
requested review from
penghuo,
joshuali925,
chloe-zh and
dai-chen
Codecov Report
@@ Coverage Diff @@
## develop #1028 +/- ##
==========================================
Coverage 99.89% 99.89%
Complexity 2402 2402
==========================================
Files 234 234
Lines 5464 5464
Branches 326 326
==========================================
Hits 5458 5458
Misses 5 5
Partials 1 1 Continue to review full report at Codecov.
|
joshuali925
reviewed
Feb 4, 2021
There was a problem hiding this comment.
Could you also bump these please. I think in 7.10.2 kibana's node version is upgraded, you might also need to change node version in workbench's package.json
.github/workflows/sql-workbench-release-workflow.yml
10: OD_VERSION: 1.12.0.0
.github/workflows/sql-workbench-test-and-build-workflow.yml
7: OD_VERSION: 1.12.0.0
workbench/kibana.json
3: "version": "1.12.0.0",
sql-cli/src/odfe_sql_cli/__init__.py
15:__version__ = "1.12.0.0"
sql-jdbc/src/main/java/com/amazon/opendistroforelasticsearch/jdbc/internal/Version.java
22: Current(1, 12, 0, 0);
sql-odbc/src/CMakeLists.txt
81:set(DRIVER_PACKAGE_VERSION "1.12.0.0")
82:set(DRIVER_PACKAGE_VERSION_COMMA_SEPARATED "1,12,0,0")
sql-odbc/src/TableauConnector/odfe_sql_odbc/manifest.xml
3:<connector-plugin class='odfe_sql_odbc' superclass='odbc' plugin-version='1.12.0.0' name='SQL' version='18.1' min-version-tableau='2020.1'>
sql-odbc/src/TableauConnector/odfe_sql_odbc_dev/manifest.xml
3:<connector-plugin class='odfe_sql_odbc_dev' superclass='odbc' plugin-version='1.12.0.0' name='Open Distro for Elasticsearch SQL ODBC DEV' version='18.1' min-version-tableau='2020.1'>
workbench/package.json
3: "version": "1.12.0.0",
.github/workflows/sql-workbench-release-workflow.yml
34: ref: 7.10.0
.github/workflows/sql-workbench-test-and-build-workflow.yml
22: ref: v7.10.0
workbench/kibana.json
4: "kibanaVersion": "7.10.0",
workbench/package.json
9: "version": "7.10.0",
workbench/.cypress/integration/ui.spec.js
172: 'kbn-version': '7.10.0',
release-notes/opendistro-for-elasticsearch-sql.release-notes-1.13.0.0.md
Outdated
Show resolved
Hide resolved
Was originally planning to post a separate PR for workbench but will add the other files and add workbench to this PR if the changes are minimal |
joshuali925
reviewed
Feb 4, 2021
release-notes/opendistro-for-elasticsearch-sql.release-notes-1.13.0.0.md
Outdated
Show resolved
Hide resolved
chloe-zh
approved these changes
Feb 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Query workbench bump will come in separate PR
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.