Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Workflow Fix for JDBC & Workbench #1030

Conversation

davidcui1225
Copy link
Contributor

Issue #, if available:
N/A
Description of changes:
Fix workflow credentials for JDBC and s3 bucket name for workbench

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@@ -37,6 +37,13 @@ jobs:
run: |
./gradlew publishShadowPublicationToInternal-releasesRepository '-Dorg.gradle.jvmargs=--add-modules java.xml.bind' -Dbuild.snapshot=false

- name: Configure Staging AWS Credentials
uses: aws-actions/configure-aws-credentials@v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jdbc needs AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY to build?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently the build is failing with an Access denied error, after a short working session with Sreekar from infra team he suggested using this workaround

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #1030 (7dd422b) into develop (0a16ecf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1030   +/-   ##
==========================================
  Coverage      99.89%   99.89%           
  Complexity      2402     2402           
==========================================
  Files            234      234           
  Lines           5464     5464           
  Branches         326      326           
==========================================
  Hits            5458     5458           
  Misses             5        5           
  Partials           1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a16ecf...7dd422b. Read the comment docs.

@joshuali925
Copy link
Contributor

got it, could you also add back cd kibana/plugins/workbench in here above line 62? I think it was accidentally removed in staging bucket change, without cd the working directory is not right and ls doesn't work

run: |
zip=`ls ./build/*.zip`

@davidcui1225
Copy link
Contributor Author

got it, could you also add back cd kibana/plugins/workbench in here above line 62? I think it was accidentally removed in staging bucket change, without cd the working directory is not right and ls doesn't work

run: |
zip=`ls ./build/*.zip`

Will do, maybe that is why the workbench is failing too

@davidcui1225 davidcui1225 merged commit 86c48e3 into opendistro-for-elasticsearch:develop Feb 5, 2021
@davidcui1225 davidcui1225 deleted the sql-jdbc-workflow-fix branch February 5, 2021 02:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants