-
Notifications
You must be signed in to change notification settings - Fork 186
Workflow Fix for JDBC & Workbench #1030
Workflow Fix for JDBC & Workbench #1030
Conversation
@@ -37,6 +37,13 @@ jobs: | |||
run: | | |||
./gradlew publishShadowPublicationToInternal-releasesRepository '-Dorg.gradle.jvmargs=--add-modules java.xml.bind' -Dbuild.snapshot=false | |||
|
|||
- name: Configure Staging AWS Credentials | |||
uses: aws-actions/configure-aws-credentials@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jdbc needs AWS_ACCESS_KEY_ID
and AWS_SECRET_ACCESS_KEY
to build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the build is failing with an Access denied
error, after a short working session with Sreekar from infra team he suggested using this workaround
Codecov Report
@@ Coverage Diff @@
## develop #1030 +/- ##
==========================================
Coverage 99.89% 99.89%
Complexity 2402 2402
==========================================
Files 234 234
Lines 5464 5464
Branches 326 326
==========================================
Hits 5458 5458
Misses 5 5
Partials 1 1 Continue to review full report at Codecov.
|
got it, could you also add back sql/.github/workflows/sql-workbench-release-workflow.yml Lines 61 to 62 in 2f2d8c3
|
Will do, maybe that is why the workbench is failing too |
Issue #, if available:
N/A
Description of changes:
Fix workflow credentials for JDBC and s3 bucket name for workbench
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.