This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Keep mismatch results when error occurs in comparison test #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dai-chen
added
bug
dai-chen
changed the title
penghuo
approved these changes
Jul 10, 2020
penghuo
pushed a commit
to penghuo/sql
that referenced
this pull request
Aug 6, 2022
…search#575) To make notifications more useful, add the manifest files that are generated which have paths to all created artifacts. Had to use stash/unstash in order to save and recover the message information otherwise when build jobs are parallalized the notification would break. Resolves opendistro-for-elasticsearch#557 Signed-off-by: Peter Nied <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #558
Description of changes: Previously when mismatch and exception mixed, mismatch info was ignored when error reported with confusing "No other database supports this query". In this PR, failure is reported instead of error with both mismatch info and error message included.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.