This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
ODBC: Remove catalog support from driver #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupal-bq
reviewed
Jul 11, 2020
sql-odbc/src/odfesqlodbc/es_info.cpp
Outdated
| @@ -729,6 +734,15 @@ ESAPI_Tables(HSTMT hstmt, const SQLCHAR *catalog_name_sql, | |||
| std::string query; | |||
| GenerateTableQuery(query, flag, table_name, result_type, table_valid); | |||
|
|
|||
| // Get list of columns with SELECT * query since columns doesn't match | |||
There was a problem hiding this comment.
IIRC, this won't be applicable here since SQLTables is using SHOW TABLES query which doesn't have column information.
There was a problem hiding this comment.
And list_of_columns isn't used in this function afterwards
There was a problem hiding this comment.
Misplaced changes; will remove
rupal-bq
approved these changes
Jul 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #565
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.