Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix for query folding issue with direct query mode in Power BI data connector #640

Merged
Merged
Show file tree
Hide file tree
Changes from 31 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
427bd79
pbi connector
Jul 19, 2020
401a053
update names
Jul 19, 2020
11856cd
- add mez file
Jul 20, 2020
e693269
nit
Jul 20, 2020
4158974
nit
Jul 20, 2020
586793f
image resize
Jul 20, 2020
9cb48a4
resize image
Jul 20, 2020
c234b88
remove extra lines
Jul 20, 2020
0d0c050
nit
Jul 20, 2020
50d4ccf
update mez file
Jul 20, 2020
023fb67
rename connector
Jul 21, 2020
0b857c0
rename mez file
Jul 21, 2020
06ae486
- add basic & aws auth
Jul 23, 2020
b2ff222
Merge branch 'develop' of https://github.com/rupal-bq/sql into featur…
Jul 23, 2020
3f6ff5d
add connector
Jul 23, 2020
ad73d91
update doc
Jul 23, 2020
91d5cbe
add ssl for auth
Jul 23, 2020
ddc725b
update docs for errors
Jul 23, 2020
b946351
Merge branch 'develop' of https://github.com/rupal-bq/sql into featur…
Jul 23, 2020
2bd944c
- remove sqlgetinfo & sqlcapabilities values from connector
Jul 24, 2020
ed0afb9
adding EncryptedConnectionString
Jul 24, 2020
22dc963
Merge branch 'develop' of https://github.com/rupal-bq/sql into featur…
Jul 28, 2020
82e9a72
add data type for columns
Jul 28, 2020
5022f1f
add alternate column size
Jul 28, 2020
f4c7068
reverting changes in catalog test
Jul 28, 2020
a76c382
nit
Jul 28, 2020
debe0c5
revert changes for column size validation
Jul 28, 2020
6add9da
Merge branch 'develop' of https://github.com/rupal-bq/sql into featur…
Jul 28, 2020
a80eee8
address PR comments
Jul 29, 2020
e6490e4
Update SQL_GROUP_BY value for fixing query folding issue
Jul 29, 2020
e1032c3
Merge branch 'develop' of https://github.com/rupal-bq/sql into featur…
Jul 29, 2020
9a36d47
removing AstVisitor for resolving query folding issue with data type …
Jul 30, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ TEST_SQL_GET_INFO_VERSION_GE(SQLDBMSVer, SQL_DBMS_VER, L"7.1.1");

TEST_SQL_GET_INFO_STRING(SQLColumnAlias, SQL_COLUMN_ALIAS, L"Y");
TEST_SQL_GET_INFO_UINT16(SQLGroupBy, SQL_GROUP_BY,
SQL_GB_GROUP_BY_EQUALS_SELECT);
SQL_GB_GROUP_BY_CONTAINS_SELECT);
TEST_SQL_GET_INFO_STRING(SQLIdentifierQuoteChar, SQL_IDENTIFIER_QUOTE_CHAR,
L"`");
TEST_SQL_GET_INFO_UINT_MASK(SQLOJCapabilities, SQL_OJ_CAPABILITIES,
Expand Down
5 changes: 5 additions & 0 deletions sql-odbc/src/PowerBIConnector/OdfeSqlOdbcPBIConnector.pq
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,10 @@ OdfeSqlOdbcPBIConnectorImpl = (Host as text, optional Port as number) as table =
Driver = "ODFE SQL ODBC Driver"
],

SQLGetInfo = Diagnostics.LogValue("SQLGetInfo_Options", [
SQL_AGGREGATE_FUNCTIONS = ODBC[SQL_AF][All]
]),

SQLGetTypeInfo = (types) =>
if (EnableTraceOutput <> true) then types else
let
Expand Down Expand Up @@ -139,6 +143,7 @@ OdfeSqlOdbcPBIConnectorImpl = (Host as text, optional Port as number) as table =
AstVisitor = AstVisitor,
SQLColumns = SQLColumns,
SQLGetTypeInfo = SQLGetTypeInfo,
SQLGetInfo = SQLGetInfo,

OnError = OnOdbcError,

Expand Down
Binary file not shown.
2 changes: 1 addition & 1 deletion sql-odbc/src/odfesqlodbc/info.c
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ RETCODE SQL_API ESAPI_GetInfo(HDBC hdbc, SQLUSMALLINT fInfoType,

case SQL_GROUP_BY: /* ODBC 2.0 */
len = 2;
value = SQL_GB_GROUP_BY_EQUALS_SELECT;
value = SQL_GB_GROUP_BY_CONTAINS_SELECT;
break;

case SQL_IDENTIFIER_CASE: /* ODBC 1.0 */
Expand Down