This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Parse backtick strings (``) as identifiers instead of string literals #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupal-bq
reviewed
Aug 11, 2020
|
Yes, thanks for the reminder 👍 |
jordanw-bq
commented
Aug 11, 2020
| @Test | ||
| public void queryWithBackticksQuotedFieldNameInFunctionShouldPass() { | ||
| validate("SELECT SUM(`age`) FROM semantics"); | ||
| } |
There was a problem hiding this comment.
@rupal-bq Added test
rupal-bq
approved these changes
Aug 11, 2020
dai-chen
approved these changes
Aug 11, 2020
chloe-zh
approved these changes
Aug 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #634
Description of changes:
Thanks @dai-chen for the fix suggestions! (#634 (comment))
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.