This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 186
Support WHERE clause in new SQL parser #682
Merged
dai-chen
merged 10 commits into
opendistro-for-elasticsearch:develop
from
dai-chen:support-where-in-new-engine
Aug 19, 2020
Merged
Support WHERE clause in new SQL parser #682
dai-chen
merged 10 commits into
opendistro-for-elasticsearch:develop
from
dai-chen:support-where-in-new-engine
Aug 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dai-chen
changed the title
Support where in new engine
Support WHERE clause in new SQL parser
Aug 13, 2020
dai-chen
force-pushed
the
support-where-in-new-engine
branch
from
August 17, 2020 18:48
6dfc81c
to
0b2c435
Compare
chloe-zh
approved these changes
Aug 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
penghuo
approved these changes
Aug 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
With
WHERE
clause enabled in new engine, the following issues can be resolved:LIKE
text issueDescription of changes: Changed new SQL parser grammar to enable
WHERE
clause and logical expressions (AND
,OR
,NOT
).Testing: Added new UT and IT (comparison test). Added test for the issues above to verify the fix.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.