This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 186
Support ranking window functions #753
Merged
dai-chen
merged 40 commits into
opendistro-for-elasticsearch:develop
from
dai-chen:window-function-poc
Oct 9, 2020
Merged
Support ranking window functions #753
dai-chen
merged 40 commits into
opendistro-for-elasticsearch:develop
from
dai-chen:window-function-poc
Oct 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penghuo
reviewed
Oct 5, 2020
penghuo
approved these changes
Oct 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change.
chloe-zh
approved these changes
Oct 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #751
Description of changes: This PR is to add basic support for ranking window functions.
ROW_NUMBER
,RANK
andDENSE_RANK
.PPL_ASC/DESC
toDEFAULT_ASC/DESC
.To-Dos: Window function name: for now toString() is used as symbol name. This restricts multiple use of same window function, ex.
SELECT RANK() OVER(...), RANK() OVER(...)
.Design: In Abstract Syntax Tree (AST), the window function is still on the project item list in Project AST node. After analyzing, it is separated into an individual logical Window operator with window function and its definition along with Sort operator that guarantee order of input data of window operator. Eventually both converts to its correspondent physical operators.
Testing: Add UT and comparison test: https://github.com/dai-chen/sql/blob/window-function-poc/integ-test/src/test/resources/correctness/queries/window.txt
Documentation: (Note that you need to enable the new SQL engine to try out this feature: https://github.com/opendistro-for-elasticsearch/sql/blob/master/docs/user/admin/settings.rst#opendistro-sql-engine-new-enabled)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.