Bump jackson-databind version to 2.10.5.1 #984
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #984 +/- ##
==========================================
Coverage 99.87% 99.87%
Complexity 2383 2383
==========================================
Files 234 234
Lines 5470 5470
Branches 357 357
==========================================
Hits 5463 5463
Misses 5 5
Partials 2 2 Continue to review full report at Codecov.
|
plugin/build.gradle
Outdated
| @@ -31,6 +31,7 @@ thirdPartyAudit.enabled = false | |||
| configurations.all { | |||
| // conflict with spring-jcl | |||
| exclude group: "commons-logging", module: "commons-logging" | |||
| exclude group: 'com.fasterxml.jackson.core', module: 'jackson-core' | |||
There was a problem hiding this comment.
I assume this is supposed to be same resolutionStrategy.force as above? Otherwise, although all IT passed, our plugin will have problem at runtime. Please confirm and do sanity test by running all ITs with remote ES cluster with our plugin built from your branch.
There was a problem hiding this comment.
Reference: ./gradlew integTest -Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername=es-integrationtest -Dtests.class="*SQLCorrectnessIT" -Dhttps=true -Duser=admin -Dpassword=admin in #760
Issue #, if available:
N/A
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.