Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

Add missing sql settings #499

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Conversation

lizsnyder
Copy link
Contributor

Description of changes:

Adding missing settings per https://github.com/opendistro-for-elasticsearch/sql/blob/develop/docs/user/admin/settings.rst

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lizsnyder
Copy link
Contributor Author

@aetter @chloe-zh for some reason it's not letting me add reviewers so tagging here for visibility

Copy link

@chloe-zh chloe-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!
I remember we have removed these settings but then added them back and deprecated them. Could you take a look to see if these settings are necessary to add to the docs accordingly? @dai-chen

@lizsnyder
Copy link
Contributor Author

Thanks @chloe-zh. We received feedback that the “opendistro.sql.engine.new.enabled” setting must be set to true in order for the date and time SQL functions to work in Elasticsearch 7.9. Looking into that led me to realize that the setting wasn't documented in the ODFE docs. Maybe @dai-chen can shed some light on this.

@dai-chen
Copy link
Contributor

These 2 settings were added later without updating the documentation. @chloe-zh I guess you said is for OpenSearch setting docs.

Copy link

@chloe-zh chloe-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@keithhc2 keithhc2 merged commit b660644 into opendistro:master Jul 20, 2021
@lizsnyder lizsnyder deleted the sql-settings branch July 20, 2021 18:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants