Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add golangci-lint to actions #60

Merged
merged 1 commit into from
Jul 17, 2021
Merged

feat: add golangci-lint to actions #60

merged 1 commit into from
Jul 17, 2021

Conversation

burntcarrot
Copy link
Contributor

@burntcarrot burntcarrot commented Jul 17, 2021

Fixes #51.

Changes:

  • add golangci-lint as an action
  • modify golint target in Makefile
  • move license check to goheader

Signed-off-by: Aadhav Vignesh [email protected]

Changes:
- add golangci-lint as an action
- modify golint target in Makefile
- move license check to goheader

Signed-off-by: Aadhav Vignesh <[email protected]>
Copy link
Member

@vharsh vharsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vharsh
Copy link
Member

vharsh commented Jul 17, 2021

Thanks for the PR @burntcarrot 😃🎉

@vharsh vharsh merged commit e182f4a into openebs:develop Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add go linting tools to CI
2 participants