Paragon table deprecation migration to DataTable #200
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #200 +/- ##
=======================================
Coverage 57.04% 57.04%
=======================================
Files 29 29
Lines 305 305
Branches 64 64
=======================================
Hits 174 174
Misses 126 126
Partials 5 5
☔ View full report in Codecov by Sentry. |
|
based on #191 |
|
@colinbrash please review / merge. Thank you! |
|
@arbrandes would you mind taking a look at this? It's been open for a bit - seeing if it can get reviewed. |
|
@mphilbrick211, prior to the Olive release I don't think I'll have time to test this properly, but I'll add it to my list! |
|
@pshiu, another ecommerce one, if you happen to have some time. Thanks! |
There was a problem hiding this comment.
Thanks for including the feedback from #191!
I see that a pagination was added with Prev/Next buttons, in the screenshot there's only 1 course with 2 pages, is that accurate with what prod will have? I believe this MFE uses pageSize as a determinant for how many pages it should have, is this a bug?
If we're using the Prev/Next (vs. Showing 1 of 2), could you adjust the padding? It looks like the buttons are overlaid on top of the table border.
…to abdullahwaheed/paragon-table-deprecations
|
@julianajlk that's an old PR but i think i was testing pagination with 2 entries by manually setting up limit to 1 item per page. Let me test it again with some more data |
|
Tested again, screenshot was added to show the change with dummy data and page size was set to 1 explicitly to show pagination. Also fixed the design of pagination footer. Its not ready to review and merge
|
abdullahwaheed
requested review from
julianajlk
and removed request for
colinbrash and
pshiu
Thanks for testing! How will it look like with multiple pages? |
It looks like this
|
|
@julianajlk any updates on this? |
|
I'm technically not allowed to merge this, either. @abdullahwaheed, do you mind resolving conflicts? Then I'll try and get the owning team to merge it. |
I'll update it |
…to abdullahwaheed/paragon-table-deprecations
* Update standard workflow files. (#263) * build: Create a missing workflow file `self-assign-issue.yml`. The .github/workflows/self-assign-issue.yml workflow is missing or needs an update to stay in sync with the current standard for this workflow as defined in the `.github` repo of the `openedx` GitHub org. * build: Create a missing workflow file `add-remove-label-on-comment.yml`. The .github/workflows/add-remove-label-on-comment.yml workflow is missing or needs an update to stay in sync with the current standard for this workflow as defined in the `.github` repo of the `openedx` GitHub org. * build: Update a workflow file `add-depr-ticket-to-depr-board.yml`. The .github/workflows/add-depr-ticket-to-depr-board.yml workflow is missing or needs an update to stay in sync with the current standard for this workflow as defined in the `.github` repo of the `openedx` GitHub org. * chore(i18n): add more languages (#261) * chore(i18n): add more languages * chore(i18n): Pylint fixes * feat: use `atlas` in `make pull_translations` (#278) Changes ------- - Bump frontend-platform to bring `intl-imports.js` script - Move all i18n imports into `src/i18n/index.js` so `intl-imports.js` can override it with latest translations - Add `atlas` into `make pull_translations` when `OPENEDX_ATLAS_PULL` environment variable is set. Refs: [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) implementing Translation Infrastructure OEP-58. * feat: upgraded to node v18, added .nvmrc and updated workflows (#274) * feat: upgraded to node v18, added .nvmrc and updated workflows * build: update frontrnf-build * build: upgrade pkgs * build: update @edx/browserslist-config to the latest * refactor: update packages * feat: add subscriptions section to orders page (#289) * feat: design changes for subscriptions (#276) * feat: api integration for subscription related changes (#282) * feat: add manage subscriptions url and update subscription upsell (#288) * test: add more tests for subscriptions --------- Co-authored-by: Nawfal Ahmed <[email protected]> Co-authored-by: Nawfal Ahmed <[email protected]> * fix: fix getting b2c subscriptions flag for stage (#290) * refactor: update components and utils folder structure * feat: improve subscription section and add basic alerts * fix: revert change to container (#292) * Automate Browserlist DB Update (#221) * feat: added cron github action to auto update brwoserlist DB periodically * refactor: used a shared script to update broswerslist DB, create PR and automerge it * Paragon table deprecation migration to DataTable (#200) * refactor: changed derecated table component to datatable * refactor: fixed warning of missing props * refactor: changed DataTable to DataTable.Table as suggested in code review * refactor: used DataTable.Table directly to remove count * fix: fixed pagination styling issue * fix: fixed snapshot test * PON-251: Update Existing Error Handling (#294) * feat: update order history error flows * refactor: remove unused AsyncActionType, favour saga routines over this * fix: add sr message to loading, fix order history loading * test: add more tests for coverage * feat: update error UX for manage subscriptions (#299) * chore(i18n): update translations (#301) Co-authored-by: Jenkins <[email protected]> * feat: handle subscription api statuscode flag (#304) * feat: add translations for subscription state badges (#305) * fix: fix unmarked translations (#306) * chore(i18n): update translations * chore(i18n): update translations (#308) Co-authored-by: Jenkins <[email protected]> * feat: add subscriptions marketing url (#309) * docs: update readme to reflect recent subscription changes (#312) * feat: move subscription upsell values behind env (#314) * feat: use react-testing-library for detailed unit tests (#316) * feat: use react-testing-library for tests * feat: update tests for Subscriptions * feat: update tests for NotFoundPage * feat: update tests for ManageSubscriptions * feat: update tests for OrdersandSubscriptions * chore: added CODEOWNERS file to enable branch protection policy (REV-3441) (#283) * chore: added CODEOWNERS file to enable branch protection policy * fix: updated @edx/revenue-squad team tag * fix: updated @openedx/revenue-squad team tag * chore: added self check for CODEOWNERS file and updated file path to /src * feat: disable subscriptions for local (#318) * Removed subscription section from Readme file (#322) * fix: removed subscription section and subs screenshot from readme file * feat: update react & react-dom to v17 (#302) * feat: update react & react-dom to v17 * build: update edx pkgs * build: update lock file --------- Co-authored-by: Feanil Patel <[email protected]> Co-authored-by: Yoiber <[email protected]> Co-authored-by: Omar Al-Ithawi <[email protected]> Co-authored-by: Mashal Malik <[email protected]> Co-authored-by: Shafqat Farhan <[email protected]> Co-authored-by: Nawfal Ahmed <[email protected]> Co-authored-by: Nawfal Ahmed <[email protected]> Co-authored-by: Muhammad Abdullah Waheed <[email protected]> Co-authored-by: edx-transifex-bot <[email protected]> Co-authored-by: Jenkins <[email protected]> Co-authored-by: Muhammad Mattiullah <[email protected]> Co-authored-by: Shahroz Ahmad <[email protected]>
Ticket
Migrate off deprecated Paragon components
What has changed
Removed deprecated
Tablecomponent of paragon and updated it withDataTableReferences
Paragon Table
Paragon DataTable