Skip to content
This repository has been archived by the owner on Sep 3, 2024. It is now read-only.

feat: react based studio footer #359

Merged
merged 5 commits into from
Jul 11, 2023
Merged

Conversation

KristinAoki
Copy link
Contributor

@KristinAoki KristinAoki commented Jul 10, 2023

This a rebuild of the current studio footer using React. The footer should have the same content as the existing footer.

For testing use course-authoring PR 532. The footer can be seen on at the bottom of Pages & Resources.

@KristinAoki KristinAoki marked this pull request as ready for review July 10, 2023 17:28
Copy link
Contributor

@connorhaugh connorhaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assumptions I have made for this review:

  • The content/layout is correct (no mocks exist)
  • You have made the choice to not put this in the footer library for a good reason.
  • Code style is out of the window, as a lot of this is borrowed code.

src/footer/Footer.jsx Show resolved Hide resolved
src/footer/Footer.test.jsx Outdated Show resolved Hide resolved
src/footer/Footer.test.jsx Show resolved Hide resolved
@KristinAoki
Copy link
Contributor Author

Assumptions I have made for this review:

  • The content/layout is correct (no mocks exist)

Yes, content is matching the current footer in legacy studio. The coloring is set to match all the design patterns of the pages.

  • You have made the choice to not put this in the footer library for a good reason.

I am following the pattern of not including the header in the header library.

  • Code style is out of the window, as a lot of this is borrowed code.

@connorhaugh what do you mean by code style?

src/footer/Footer.jsx Outdated Show resolved Hide resolved
src/footer/Footer.jsx Outdated Show resolved Hide resolved
@connorhaugh
Copy link
Contributor

@connorhaugh what do you mean by code style?

cleaner code, principally breaking jsx into smaller components to be more readable. Not the end of the world in this case if it makes things harder.

@KristinAoki KristinAoki merged commit 3586307 into main Jul 11, 2023
4 checks passed
@jesperhodge jesperhodge mentioned this pull request Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants