This repository has been archived by the owner on Sep 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristinAoki
requested review from
kenclary,
jesperhodge,
connorhaugh and
rayzhou-bit
July 10, 2023 17:31
connorhaugh
reviewed
Jul 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assumptions I have made for this review:
- The content/layout is correct (no mocks exist)
- You have made the choice to not put this in the footer library for a good reason.
- Code style is out of the window, as a lot of this is borrowed code.
Yes, content is matching the current footer in legacy studio. The coloring is set to match all the design patterns of the pages.
I am following the pattern of not including the header in the header library.
@connorhaugh what do you mean by code style? |
connorhaugh
reviewed
Jul 11, 2023
connorhaugh
reviewed
Jul 11, 2023
cleaner code, principally breaking jsx into smaller components to be more readable. Not the end of the world in this case if it makes things harder. |
connorhaugh
approved these changes
Jul 11, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a rebuild of the current studio footer using React. The footer should have the same content as the existing footer.
For testing use course-authoring PR 532. The footer can be seen on at the bottom of Pages & Resources.