Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add __init__.py to data_layer module #2020

Closed
wants to merge 4 commits into from

Conversation

UsamaSadiq
Copy link
Member

@UsamaSadiq UsamaSadiq commented Aug 8, 2023

Description

  • Previous release 5.2.2 failed when bumping the version in edx-platform in the PR due to insufficient files being published in the PyPI release.
  • Added __init__.py to xblock/data_layer module to fix the issue.
  • Bump the package version to 5.2.3 after the docs failure has been fixed.
  • If this release works successfully, the previous release 5.2.2 will need to be yanked from PyPI.
  • downgrade pylint to avoid quality failures

@UsamaSadiq UsamaSadiq requested a review from a team as a code owner August 8, 2023 14:28
@UsamaSadiq UsamaSadiq changed the title chore: bump version to 5.2.3 fix: add __init__.py to data_layer module Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (0faef57) 95.08% compared to head (ca4b643) 95.08%.

❗ Current head ca4b643 differs from pull request most recent head bac9dd8. Consider uploading reports for the commit bac9dd8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2020      +/-   ##
==========================================
- Coverage   95.08%   95.08%   -0.01%     
==========================================
  Files         158      158              
  Lines       17429    17428       -1     
  Branches     1626     1625       -1     
==========================================
- Hits        16572    16571       -1     
  Misses        642      642              
  Partials      215      215              
Flag Coverage Δ
unittests 95.08% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
openassessment/__init__.py 100.00% <100.00%> (ø)
openassessment/xblock/data_layer/serializers.py 95.76% <100.00%> (ø)
...enassessment/xblock/data_layer/test_serializers.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awais786
Copy link
Contributor

awais786 commented Aug 9, 2023

#2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants