Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: data layer API call for ORA block data" #2022

Closed
wants to merge 1 commit into from

Conversation

awais786
Copy link
Contributor

@awais786 awais786 commented Aug 8, 2023

Reverts #2002

Lots of quality issue are coming in original PR.

We are reverting this PR to unblock edx-platform sync migrations test, which is disable at the moment and need this package new version.

Sorry for the inconvenience.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.07% ⚠️

Comparison is base (0faef57) 95.08% compared to head (058d9b8) 95.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2022      +/-   ##
==========================================
- Coverage   95.08%   95.01%   -0.07%     
==========================================
  Files         158      155       -3     
  Lines       17429    17112     -317     
  Branches     1626     1615      -11     
==========================================
- Hits        16572    16259     -313     
+ Misses        642      639       -3     
+ Partials      215      214       -1     
Flag Coverage Δ
unittests 95.01% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
openassessment/xblock/openassessmentblock.py 90.37% <100.00%> (-0.03%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awais786
Copy link
Contributor Author

awais786 commented Aug 9, 2023

Found 33 pylint violations, threshold is 0
************* Module openassessment.xblock.data_layer.serializers

openassessment/xblock/data_layer/serializers.py:28: [W0223(abstract-method), TextResponseConfigSerializer] Method 'create' is abstract in class 'BaseSerializer' but is not overridden in child class 'TextResponseConfigSerializer'

openassessment/xblock/data_layer/serializers.py:28: [W0223(abstract-method), TextResponseConfigSerializer] Method 'update' is abstract in class 'BaseSerializer' but is not overridden in child class 'TextResponseConfigSerializer'

openassessment/xblock/data_layer/serializers.py:38: [W0223(abstract-method), FileResponseConfigSerializer] Method 'create' is abstract in class 'BaseSerializer' but is not overridden in child class 'FileResponseConfigSerializer'

openassessment/xblock/data_layer/serializers.py:38: [W0223(abstract-method), FileResponseConfigSerializer] Method 'update' is abstract in class 'BaseSerializer' but is not overridden in child class 'FileResponseConfigSerializer'

openassessment/xblock/data_layer/serializers.py:55: [W0223(abstract-method), TeamsConfigSerializer] Method 'create' is abstract in class 'BaseSerializer' but is not overridden in child class 'TeamsConfigSerializer'

openassessment/xblock/data_layer/serializers.py:55: [W0223(abstract-method), TeamsConfigSerializer] Method 'update' is abstract in class 'BaseSerializer' but is not overridden in child class 'TeamsConfigSerializer'

openassessment/xblock/data_layer/serializers.py:59: [R1710(inconsistent-return-statements), TeamsConfigSerializer.get_teamsetName] Either all return statements in a function should return an expression, or none of them should.

openassessment/xblock/data_layer/serializers.py:64: [W0223(abstract-method), SubmissionConfigSerializer] Method 'create' is abstract in class 'BaseSerializer' but is not overridden in child class 'SubmissionConfigSerializer'

openassessment/xblock/data_layer/serializers.py:64: [W0223(abstract-method), SubmissionConfigSerializer] Method 'update' is abstract in class 'BaseSerializer' but is not overridden in child class 'SubmissionConfigSerializer'

openassessment/xblock/data_layer/serializers.py:74: [W0223(abstract-method), RubricFeedbackConfigSerializer] Method 'create' is abstract in class 'BaseSerializer' but is not overridden in child class 'RubricFeedbackConfigSerializer'

openassessment/xblock/data_layer/serializers.py:74: [W0223(abstract-method), RubricFeedbackConfigSerializer] Method 'update' is abstract in class 'BaseSerializer' but is not overridden in child class 'RubricFeedbackConfigSerializer'

openassessment/xblock/data_layer/serializers.py:79: [W0223(abstract-method), RubricCriterionOptionSerializer] Method 'create' is abstract in class 'BaseSerializer' but is not overridden in child class 'RubricCriterionOptionSerializer'

openassessment/xblock/data_layer/serializers.py:79: [W0223(abstract-method), RubricCriterionOptionSerializer] Method 'update' is abstract in class 'BaseSerializer' but is not overridden in child class 'RubricCriterionOptionSerializer'

openassessment/xblock/data_layer/serializers.py:86: [W0223(abstract-method), RubricCriterionSerializer] Method 'create' is abstract in class 'BaseSerializer' but is not overridden in child class 'RubricCriterionSerializer'

openassessment/xblock/data_layer/serializers.py:86: [W0223(abstract-method), RubricCriterionSerializer] Method 'update' is abstract in class 'BaseSerializer' but is not overridden in child class 'RubricCriterionSerializer'

openassessment/xblock/data_layer/serializers.py:103: [W0223(abstract-method), RubricConfigSerializer] Method 'create' is abstract in class 'BaseSerializer' but is not overridden in child class 'RubricConfigSerializer'

openassessment/xblock/data_layer/serializers.py:103: [W0223(abstract-method), RubricConfigSerializer] Method 'update' is abstract in class 'BaseSerializer' but is not overridden in child class 'RubricConfigSerializer'

openassessment/xblock/data_layer/serializers.py:111: [W0223(abstract-method), SelfSettingsSerializer] Method 'create' is abstract in class 'BaseSerializer' but is not overridden in child class 'SelfSettingsSerializer'

openassessment/xblock/data_layer/serializers.py:111: [W0223(abstract-method), SelfSettingsSerializer] Method 'update' is abstract in class 'BaseSerializer' but is not overridden in child class 'SelfSettingsSerializer'

openassessment/xblock/data_layer/serializers.py:118: [W0223(abstract-method), PeerSettingsSerializer] Method 'create' is abstract in class 'BaseSerializer' but is not overridden in child class 'PeerSettingsSerializer'

openassessment/xblock/data_layer/serializers.py:118: [W0223(abstract-method), PeerSettingsSerializer] Method 'update' is abstract in class 'BaseSerializer' but is not overridden in child class 'PeerSettingsSerializer'

openassessment/xblock/data_layer/serializers.py:132: [W0223(abstract-method), AssessmentStepSettingsSerializer] Method 'create' is abstract in class 'BaseSerializer' but is not overridden in child class 'AssessmentStepSettingsSerializer'

openassessment/xblock/data_layer/serializers.py:132: [W0223(abstract-method), AssessmentStepSettingsSerializer] Method 'update' is abstract in class 'BaseSerializer' but is not overridden in child class 'AssessmentStepSettingsSerializer'

openassessment/xblock/data_layer/serializers.py:151: [W0237(arguments-renamed), AssessmentStepSettingsSerializer.to_representation] Parameter 'instance' has been renamed to 'rubric_assessments' in overriding 'AssessmentStepSettingsSerializer.to_representation' method

openassessment/xblock/data_layer/serializers.py:167: [W0223(abstract-method), AssessmentStepsSettingsSerializer] Method 'create' is abstract in class 'BaseSerializer' but is not overridden in child class 'AssessmentStepsSettingsSerializer'

openassessment/xblock/data_layer/serializers.py:167: [W0223(abstract-method), AssessmentStepsSettingsSerializer] Method 'update' is abstract in class 'BaseSerializer' but is not overridden in child class 'AssessmentStepsSettingsSerializer'

openassessment/xblock/data_layer/serializers.py:183: [W0223(abstract-method), AssessmentStepsSerializer] Method 'create' is abstract in class 'BaseSerializer' but is not overridden in child class 'AssessmentStepsSerializer'

openassessment/xblock/data_layer/serializers.py:183: [W0223(abstract-method), AssessmentStepsSerializer] Method 'update' is abstract in class 'BaseSerializer' but is not overridden in child class 'AssessmentStepsSerializer'

openassessment/xblock/data_layer/serializers.py:191: [W0223(abstract-method), LeaderboardConfigSerializer] Method 'create' is abstract in class 'BaseSerializer' but is not overridden in child class 'LeaderboardConfigSerializer'

openassessment/xblock/data_layer/serializers.py:191: [W0223(abstract-method), LeaderboardConfigSerializer] Method 'update' is abstract in class 'BaseSerializer' but is not overridden in child class 'LeaderboardConfigSerializer'

openassessment/xblock/data_layer/serializers.py:1[99](https://github.com/openedx/edx-ora2/actions/runs/5803174716/job/15730787904?pr=2020#step:9:100): [W0223(abstract-method), OraBlockInfoSerializer] Method 'create' is abstract in class 'BaseSerializer' but is not overridden in child class 'OraBlockInfoSerializer'

openassessment/xblock/data_layer/serializers.py:199: [W0223(abstract-method), OraBlockInfoSerializer] Method 'update' is abstract in class 'BaseSerializer' but is not overridden in child class 'OraBlockInfoSerializer'

openassessment/xblock/data_layer/serializers.py:214: [W0212(protected-access), OraBlockInfoSerializer.get_baseAssetUrl] Access to a protected member _get_base_url_path_for_course_assets of a client class

@awais786 awais786 marked this pull request as ready for review August 9, 2023 00:07
@awais786 awais786 requested a review from a team as a code owner August 9, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant