Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mattcarter/au-1388 fix make local install #2018

Merged
merged 4 commits into from
Aug 17, 2023

Conversation

mattcarter
Copy link
Contributor

@mattcarter mattcarter commented Aug 7, 2023

Does what it says. Fix for the change in the container name.

JIRA: AU-1388

Developer Checklist

Testing Instructions

  1. Launch devstack. Start both the LMS and CMS (nee, studio) containers.
  2. From ora checkout root directory, run make install-local-ora and have it complete successfully.

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@mattcarter mattcarter requested a review from a team as a code owner August 7, 2023 21:00
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (dcabc55) 95.09% compared to head (c2f315f) 95.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2018   +/-   ##
=======================================
  Coverage   95.09%   95.09%           
=======================================
  Files         158      158           
  Lines       17420    17420           
  Branches     1622     1622           
=======================================
  Hits        16566    16566           
  Misses        641      641           
  Partials      213      213           
Flag Coverage Δ
unittests 95.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
openassessment/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattcarter mattcarter changed the title Mattcarter/au 1388 fix make local install Mattcarter/au-1388 fix make local install Aug 8, 2023
@mattcarter mattcarter merged commit 4550e49 into master Aug 17, 2023
6 checks passed
@mattcarter mattcarter deleted the mattcarter/AU-1388-fix-make-local-install branch August 17, 2023 12:12
muselesscreator added a commit that referenced this pull request Aug 21, 2023
* Mattcarter/au-1388 fix make local install (#2018)

* chore: update make install-local-ora to reference cms rather than studio

* chore: version bump

* feat: create ORA "date_config_type" field (#2013)

* feat: add date_config_type field

* docs: remove finished TODO

* chore(i18n): update translations

---------

Co-authored-by: Matthew Carter <[email protected]>
Co-authored-by: leangseu-edx <[email protected]>
Co-authored-by: Ned Batchelder <[email protected]>
Co-authored-by: Jenkins <[email protected]>
BryanttV pushed a commit to eduNEXT/edx-ora2 that referenced this pull request Feb 6, 2024
* chore: update make install-local-ora to reference cms rather than studio

* chore: version bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants