fix: data layer quality fixes #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
leangseu-edx
approved these changes
Aug 9, 2023
|
Note: I'm ignoring codecov here, is irrelevant for this PR. |
BryanttV
pushed a commit
to eduNEXT/edx-ora2
that referenced
this pull request
Feb 6, 2024
* fix: add missing __init__.py * fix: pylint quality issues * chore: bump ORA to version 5.2.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR - I forgot an
__init__.pyin the originaldata_layerdirectory, which means quality checks weren't getting run and this is breaking things for other folks. So imma fix it now.Developer Checklist
Testing Instructions
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora