Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add icons to draw attention to date config #2040

Merged
merged 10 commits into from
Sep 5, 2023

Conversation

jansenk
Copy link
Contributor

@jansenk jansenk commented Aug 30, 2023

TL;DR - Add some icons to draw attention to date config

JIRA: AU-1432

What changed?

  • Added fa star to the schedule tab
  • Added a NEW badge next to the config radio selct
Screenshot 2023-09-01 at 11 15 46 AM

Developer Checklist

FYI: @openedx/content-aurora

@jansenk jansenk requested a review from a team as a code owner August 30, 2023 16:38
@jansenk jansenk changed the title Jkantor/date config icon feat: add icons to draw attention to date config Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6679c6a) 95.10% compared to head (b0a2b3c) 95.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2040   +/-   ##
=======================================
  Coverage   95.10%   95.10%           
=======================================
  Files         158      158           
  Lines       17485    17485           
  Branches     1629     1629           
=======================================
  Hits        16629    16629           
  Misses        642      642           
  Partials      214      214           
Flag Coverage Δ
unittests 95.10% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
openassessment/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - with a non-blocking nit

Copy link
Contributor

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jansenk jansenk merged commit 807f0bd into master Sep 5, 2023
6 checks passed
@jansenk jansenk deleted the jkantor/date-config-icon branch September 5, 2023 18:17
BryanttV pushed a commit to eduNEXT/edx-ora2 that referenced this pull request Feb 6, 2024
* feat: add icons to draw attention to date config

* chore: make static

* chore: translations

* docs: expand on removal todo

* style: change icon to star

* style: update colors

* chore: build static

* chore: translations

* chore: version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants