Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable new ORA experience for leaderboards #2140

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

nsprenkle
Copy link
Contributor

TL;DR - disables ORA experience when leaderboards are enabled (not currently supported).

Developer Checklist

Testing Instructions

  1. Go to Studio
  2. Create / edit an ORA
  3. Set "Top Responses" to a non-zero value.
  4. Verify that we use the legacy ORA experience.

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d88d1a7) 94.94% compared to head (8d02423) 94.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2140   +/-   ##
=======================================
  Coverage   94.94%   94.94%           
=======================================
  Files         191      191           
  Lines       20515    20524    +9     
  Branches     1858     1859    +1     
=======================================
+ Hits        19478    19487    +9     
  Misses        777      777           
  Partials      260      260           
Flag Coverage Δ
unittests 94.94% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nsprenkle nsprenkle merged commit 9436f5e into master Dec 12, 2023
9 checks passed
@nsprenkle nsprenkle deleted the nsprenkle/new-ora-disable-on-leaderboard branch December 12, 2023 18:32
BryanttV pushed a commit to eduNEXT/edx-ora2 that referenced this pull request Feb 6, 2024
* feat: disable new ORA experience for leaderboards

* chore: bump ORA to 6.0.14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants