Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove disabled LaTex for ora mfe #2160

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Conversation

leangseu-edx
Copy link
Contributor

@leangseu-edx leangseu-edx commented Jan 10, 2024

TL;DR - remove disabled LaTex for ora mfe

JIRA: https://2u-internal.atlassian.net/browse/AU-1649

Pair pr: openedx/frontend-app-ora#168

Developer Checklist

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@leangseu-edx leangseu-edx requested a review from a team as a code owner January 10, 2024 20:09
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc53d20) 94.95% compared to head (5fd4615) 94.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2160      +/-   ##
==========================================
- Coverage   94.95%   94.95%   -0.01%     
==========================================
  Files         191      191              
  Lines       20617    20608       -9     
  Branches     1864     1863       -1     
==========================================
- Hits        19577    19568       -9     
  Misses        777      777              
  Partials      263      263              
Flag Coverage Δ
unittests 94.95% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@leangseu-edx leangseu-edx merged commit 0c02eb0 into master Jan 16, 2024
9 checks passed
@leangseu-edx leangseu-edx deleted the lk/latex-support branch January 16, 2024 16:23
BryanttV pushed a commit to eduNEXT/edx-ora2 that referenced this pull request Feb 6, 2024
* feat: remove disabled LaTex for ora mfe

* chore: remove LaTex test

* chore: version bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants