Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: incrementally upgrade npm packages #31739

Merged
merged 6 commits into from
Feb 28, 2023
Merged

chore: incrementally upgrade npm packages #31739

merged 6 commits into from
Feb 28, 2023

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Feb 10, 2023 •
edited
Loading

Ticket

openedx/wg-frontend#105

Description

This PR is extension of 30953

  1. Upgraded React v16.1.0 to v16.14.0.
  2. Upgraded React-DOM v16.1.2 to v16.14.0.
  3. All packages with patch updates are upgraded.
  4. Most of the packages with minor version updates are upgraded. Remaining are prop-types, redux-thunk and underscore. If I try to upgrade these packages, test suite starts to fail.

@BilalQamar95 BilalQamar95 marked this pull request as ready for review February 10, 2023 12:44
@BilalQamar95 BilalQamar95 self-assigned this Feb 10, 2023
@BilalQamar95 BilalQamar95 mentioned this pull request Feb 10, 2023
Closed
@abdullahwaheed abdullahwaheed merged commit 20f65ae into master Feb 28, 2023
@abdullahwaheed abdullahwaheed deleted the bilalqamar95/package-incremental-update branch February 28, 2023 05:54
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@NawfalAhmed
Copy link
Member

This package seems to have been removed from npm, I wonder if that's safe and intentional

"@edx/edx-proctoring": "^4.12.2",

@abdullahwaheed @BilalQamar95

abdullahwaheed added a commit that referenced this pull request Feb 28, 2023
@abdullahwaheed
Revert "chore: incrementally upgrade npm packages (#31739)"
032895e 
This reverts commit 20f65ae.
@BilalQamar95 BilalQamar95 mentioned this pull request Feb 28, 2023
Closed
muhammad-ammar pushed a commit that referenced this pull request Feb 28, 2023
@BilalQamar95 @muhammad-ammar
chore: incrementally upgrade npm packages (#31739)
58b44b1 
* chore: incrementally upgrade npm packages

* chore: updated packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdullahwaheed abdullahwaheed abdullahwaheed approved these changes

Assignees

@BilalQamar95 BilalQamar95

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BilalQamar95 @edx-pipeline-bot @NawfalAhmed @abdullahwaheed