Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade npm pkgs #31887

Closed
wants to merge 6 commits into from
Closed

Conversation

ghassanmas
Copy link
Member

Description

This an attemp to upgrade npm pkgs, initially I wanted just to resolve npm ci issue where there was one conflict with karma-selenium-webdriver-launcher, but resolving that lead to other conflicts pop up, ultimately lead to an upgrade webpack 2 to 4, sass-loader 6 to 10, karma 0.x to 1.x, karama-webpack 2 to 4.

I tried to follow upgrade/migrate guildline for the above packages, but I doubt that I did everything as needed.
Secondaly it was hard to debug locally because even without doing anything I had failed tests.

Related issue: openedx/wg-frontend/issues/105
Related slack thread: https://openedx.slack.com/archives/C049JQZFR5E/p1678127947313209

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 7, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 7, 2023

Thanks for the pull request, @ghassanmas! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@Majboor
Copy link

Majboor commented Apr 7, 2023

Hi there,

I think I may have found a fix for this issue. Have you tried updating the package to the latest version? You can do this by running the following command:

npm install package-name@latest

@mphilbrick211
Copy link

Hi @ghassanma - just seeing if you plan to pursue this PR, or can it be closed?

@ghassanmas ghassanmas closed this Jul 9, 2023
@openedx-webhooks
Copy link

@ghassanmas Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants