-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "feat: Account and profile MFE legacy removal - redeployment " #33542
Revert "feat: Account and profile MFE legacy removal - redeployment " #33542
Conversation
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
@abdullahwaheed @Syed-Ali-Abbas-Zaidi @Mashal-m Do you folks remember why this needed to be reverted? |
@kdmccormick looking at NewRelic data for this deployment time, I see a spike in errors of the following:
This error spike set off what looks like multiple alerts, which undoubtedly triggered the revert action. Sorry, but our NR data retention does not allow me to see more details about the error than what I pasted above. I was able to dig this up from the corresponding Slack discussion:
|
@abdullahwaheed Do you know what template it was? |
I see a reference to in |
@kdmccormick, This same toggle is being used in We also have this PR ready to remove this reference. |
Also while digging into the issue, we found out that we need to handle all the legacy redirects of the profile and account page to redirect to the profile and account MFE instead. This PR can't go in until all the redirects are handled otherwise MFEs will break. FedBom started to create the PRs to handle the redirects but I don't know if FedBom managed to create all the PRs, @abdullahwaheed will have better knowledge about it. Below are the PRs we created in profile and account MFE to handle the legacy redirects. |
Reverts #31893