Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use branch name directly #337

Merged
merged 1 commit into from
Dec 6, 2021
Merged

fix: use branch name directly #337

merged 1 commit into from
Dec 6, 2021

Conversation

Jawayria
Copy link
Contributor

@Jawayria Jawayria commented Dec 1, 2021

$default-branch is only available in workflow-templates so we'll use branch name directly in this workflow

https://stackoverflow.com/questions/64781462/github-actions-default-branch-variable

$default-branch is only available in workflow-templates so we'll use branch name directly in this workflow
@Jawayria Jawayria requested a review from a team December 1, 2021 08:03
@codecov-commenter
Copy link

Codecov Report

Merging #337 (5cd7dfd) into master (f7160d5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #337   +/-   ##
=======================================
  Coverage   94.40%   94.40%           
=======================================
  Files          28       28           
  Lines        3004     3004           
  Branches      161      161           
=======================================
  Hits         2836     2836           
  Misses        150      150           
  Partials       18       18           
Flag Coverage Δ
unittests 94.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7160d5...5cd7dfd. Read the comment docs.

Copy link
Contributor

@DawoudSheraz DawoudSheraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the purpose of $default-branch if it is not usable in workflow? Won't this cause a lot of re-edits when the default branches are renamed to main?

@Jawayria
Copy link
Contributor Author

Jawayria commented Dec 1, 2021

what's the purpose of $default-branch if it is not usable in workflow? Won't this cause a lot of re-edits when the default branches are renamed to main?

Yes we'll have to make a lot of re-edits in that case. Actually this $default-branch placeholder is used in workflow templates so that when we add a workflow in repo using that workflow template, it automatically gets replaced with default branch name.

@Jawayria Jawayria merged commit f5a246f into master Dec 6, 2021
@Jawayria Jawayria deleted the jawayria/fix-workflow branch December 6, 2021 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants