-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add data migration to backfill legacy initial deposits #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwnage101
force-pushed
the
pwnage101/ENT-9075-1
branch
2 times, most recently
from
July 9, 2024 05:06
4842d0e
to
d8a23e1
Compare
iloveagent57
reviewed
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, very clear and well-commented!
enterprise_subsidy/apps/subsidy/migrations/0022_backfill_initial_deposits.py
Outdated
Show resolved
Hide resolved
pwnage101
force-pushed
the
pwnage101/ENT-9075-1
branch
from
July 9, 2024 20:20
ee075d1
to
6b70535
Compare
pwnage101
force-pushed
the
pwnage101/ENT-9075-1
branch
4 times, most recently
from
July 10, 2024 01:34
c6c7ef2
to
0178542
Compare
pwnage101
force-pushed
the
pwnage101/ENT-9075-1
branch
2 times, most recently
from
July 10, 2024 01:46
22b1cdd
to
bc5d139
Compare
pwnage101
force-pushed
the
pwnage101/ENT-9075-1
branch
from
July 10, 2024 18:00
bc5d139
to
9568966
Compare
iloveagent57
approved these changes
Jul 10, 2024
This needs to be located in the Subsidy app instead of openedx_ledger because it relies on having access to the SubsidyReferenceChoices class. ENT-9075
This also bumps openedx-ledger to a verion (1.5.3) which supports creating "initial" Deposit objects as part of Ledger creation. ENT-9075
pwnage101
force-pushed
the
pwnage101/ENT-9075-1
branch
from
July 10, 2024 19:38
9568966
to
ce32465
Compare
I made one more change to add two more fields to the manually-created HistoricalDeposit: history_type="+",
history_change_reason="Data migration to backfill initial deposits", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be located in the Subsidy app instead of openedx_ledger because it relies on having access to the SubsidyReferenceChoices class.
ENT-9075
BLOCKED on openedx/openedx-ledger#96
BLOCKED on openedx/openedx-ledger#97