Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add data migration to backfill legacy initial deposits #269

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

pwnage101
Copy link
Contributor

@pwnage101 pwnage101 commented Jul 9, 2024

This needs to be located in the Subsidy app instead of openedx_ledger because it relies on having access to the SubsidyReferenceChoices class.

ENT-9075

BLOCKED on openedx/openedx-ledger#96
BLOCKED on openedx/openedx-ledger#97

Copy link
Contributor

@iloveagent57 iloveagent57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, very clear and well-commented!

This needs to be located in the Subsidy app instead of openedx_ledger
because it relies on having access to the SubsidyReferenceChoices class.

ENT-9075
This also bumps openedx-ledger to a verion (1.5.3) which supports
creating "initial" Deposit objects as part of Ledger creation.

ENT-9075
@pwnage101
Copy link
Contributor Author

I made one more change to add two more fields to the manually-created HistoricalDeposit:

            history_type="+",
            history_change_reason="Data migration to backfill initial deposits",

@pwnage101 pwnage101 merged commit c2fa02a into main Jul 10, 2024
7 checks passed
@pwnage101 pwnage101 deleted the pwnage101/ENT-9075-1 branch July 10, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants