fix: deposit sales references should be optional #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwnage101
force-pushed
the
pwnage101/ENT-9075-4
branch
from
1b8d3ba
to
7384a8b
Compare
adamstankiewicz
approved these changes
Jul 10, 2024
iloveagent57
approved these changes
Jul 10, 2024
This matches the upstream Subsidy fields which are also optional. This change is required to support a data migration which would otherwise fail to create deposits for subsidies that have a NULL reference_id. ENT-9075
pwnage101
force-pushed
the
pwnage101/ENT-9075-4
branch
from
7384a8b
to
65766e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the upstream Subsidy fields which are also optional. This change is required to support a data migration which would otherwise fail to create deposits for subsidies that have a NULL reference_id.
ENT-9075
BLOCKS: openedx/enterprise-subsidy#269