Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds support for filter and sort to Subsidy API #132

Merged
merged 1 commit into from
Jul 13, 2023
Merged

feat: Adds support for filter and sort to Subsidy API #132

merged 1 commit into from
Jul 13, 2023

Conversation

brobro10000
Copy link
Member

@brobro10000 brobro10000 commented Jun 26, 2023 •
edited
Loading

Adds support for filtering and sorting of subsidies.
Adds page_count on paginated data.
Allows for page_size query parameter

Added to support this ticket and PR

Tests are WIP

Description

Describe in a couple of sentences what this PR adds

Testing instructions

Add some, if applicable

Merge checklist

  • All reviewers approved
  • CI build is green
  • Documentation updated (not only docstrings)
  • Commits are squashed

@brobro10000 brobro10000 force-pushed the hu/ent-6942 branch 5 times, most recently from c8ac602 to 728c561 Compare June 27, 2023 17:51
@brobro10000 brobro10000 marked this pull request as ready for review June 27, 2023 18:02
@brobro10000 brobro10000 force-pushed the hu/ent-6942 branch 4 times, most recently from fddabaa to 1e019b9 Compare June 29, 2023 15:29
macdiesel
macdiesel reviewed Jul 6, 2023
View reviewed changes
Copy link
Contributor

@macdiesel macdiesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes?

enterprise_subsidy/apps/api/v1/views/subsidy.py Outdated Show resolved Hide resolved
enterprise_subsidy/apps/api/v1/utils.py Outdated Show resolved Hide resolved
enterprise_subsidy/apps/api/v1/views/subsidy.py Outdated Show resolved Hide resolved
enterprise_subsidy/apps/api/v1/views/subsidy.py Outdated Show resolved Hide resolved
iloveagent57
iloveagent57 reviewed Jul 11, 2023
View reviewed changes
Copy link
Contributor

@iloveagent57 iloveagent57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the one suggestion on where to compute page_count.

enterprise_subsidy/apps/api/v1/views/subsidy.py Outdated Show resolved Hide resolved
@brobro10000 brobro10000 merged commit 8e64fe5 into main Jul 13, 2023
@brobro10000 brobro10000 deleted the hu/ent-6942 branch July 13, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macdiesel macdiesel macdiesel left review comments

@iloveagent57 iloveagent57 Awaiting requested review from iloveagent57

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brobro10000 @macdiesel @iloveagent57