chore: PR feedback 2

src/components/ContentHighlights/DeleteArchivedHighlightsDialogs.jsx

@@ -95,11 +95,8 @@ const DeleteArchivedCoursesDialogs = ({
           <p>
             <FormattedMessage
               id="highlights.highlights.tab.archived.courses.modal.message"
-              defaultMessage="Deleting the archived courses in this highlight will remove it from your learners' {doubleQuote}Find a Course{doubleQuote}. This action is permanent and cannot be undone."
+              defaultMessage={"Deleting the archived courses in this highlight will remove it from your learners' \"Find a Course\". This action is permanent and cannot be undone."}
               description="Message shown in the modal to delete archived courses."
-              values={{
-                doubleQuote: '"',
-              }}
             />
           </p>
         </ModalDialog.Body>

src/components/ContentHighlights/DeleteHighlightSet.jsx

@@ -172,11 +172,8 @@ const DeleteHighlightSet = ({ enterpriseId, enterpriseSlug }) => {
         <p>
           <FormattedMessage
             id="highlights.modal.delete.highlight.confirmation.message"
-            defaultMessage="Deleting this highlight will remove it from your learners' {doubleQuote}Find a Course{doubleQuote}. This action is permanent and cannot be undone."
+            defaultMessage={"Deleting this highlight will remove it from your learners' \"Find a Course\". This action is permanent and cannot be undone."}
             description="Confirmation message shown when deleting a highlight."
-            values={{
-              doubleQuote: '"',
-            }}
           />
         </p>
       </AlertModal>

src/components/ContentHighlights/HighlightStepper/HighlightStepperTitle.jsx

@@ -32,14 +32,8 @@ const HighlightStepperTitle = () => (
             <strong>
               <FormattedMessage
                 id="highlights.new.highlights.stepper.stepper.step.pro.tip.text.create.title"
-                defaultMessage="Pro tip: we recommend naming your highlight collection to reflect skills
-                it aims to develop, or to draw the attention of specific groups it targets.
-                For example, {doubleQuote}Recommended for Marketing{doubleQuote}
-                 or {doubleQuote}Develop Leadership Skills{doubleQuote}."
+                defaultMessage={'Pro tip: we recommend naming your highlight collection to reflect skills it aims to develop, or to draw the attention of specific groups it targets. For example, "Recommended for Marketing" or "Develop Leadership Skills".'}
                 description="Create title pro tip message shown to administrators during creation of new content highlights"
-                values={{
-                  doubleQuote: '"',
-                }}
               />
             </strong>
           </p>

src/components/learner-credit-management/AssignmentEnrollByDateCell.jsx

@@ -34,12 +34,10 @@ const AssignmentEnrollByDateCell = ({ row }) => {
   const { original: { earliestPossibleExpiration: { date } } } = row;
 
   const formattedEnrollByDate = formatDate(date);
-  const isAssignmentExpiringSoon = isTodayWithinDateThreshold(
-    {
-      days: ENROLL_BY_DATE_DAYS_THRESHOLD,
-      date,
-    },
-  );
+  const isAssignmentExpiringSoon = isTodayWithinDateThreshold({
+    days: ENROLL_BY_DATE_DAYS_THRESHOLD,
+    date,
+  });
 
   return (
     <Stack direction="horizontal" gap={1}>

src/components/learner-credit-management/CancelAssignmentModal.jsx

@@ -53,9 +53,8 @@ const CancelAssignmentModal = ({
         <p>
           <FormattedMessage
             id="lcm.budget.detail.page.catalog.tab.cancel.assignment.modal.body2"
-            defaultMessage="The learner will be notified that you have canceled the assignment. The funds associated with this course assignment will move from {doubleQuote}assigned{doubleQuote} back to {doubleQuote}available{doubleQuote}."
+            defaultMessage={'The learner will be notified that you have canceled the assignment. The funds associated with this course assignment will move from "assigned" back to "available".'}
             description="Body text for the cancel assignment modal which informs the user that the learner will be notified that the assignment has been canceled."
-            values={{ doubleQuote: '"' }}
           />
         </p>
       </ModalDialog.Body>

src/components/learner-credit-management/RemindAssignmentModal.jsx

@@ -47,9 +47,8 @@ const RemindAssignmentModal = ({
         <p>
           <FormattedMessage
             id="lcm.budget.detail.page.catalog.tab.remind.assignment.modal.body2"
-            defaultMessage="When your learner completes enrollment, the associated {doubleQuote}assigned{doubleQuote} funds will be marked as {doubleQuote}spent{doubleQuote}."
+            defaultMessage={'When your learner completes enrollment, the associated "assigned" funds will be marked as "spent".'}
             description="Text2 for the body of the remind assignment modal"
-            values={{ doubleQuote: '"' }}
           />
         </p>
       </ModalDialog.Body>

src/components/learner-credit-management/assignment-modal/AssignmentAllocationHelpCollapsibles.jsx

@@ -78,23 +78,15 @@ const AssignmentAllocationHelpCollapsibles = ({ enterpriseId, course }) => (
           <li>
             <FormattedMessage
               id="lcm.budget.detailsPage.catalog.tab.course.card.total.assignment.cost"
-              defaultMessage="The total assignment cost will be earmarked as {doubleQuote}assigned{doubleQuote} funds in your
-               Learner Credit budget so you can't overspend."
+              defaultMessage={"The total assignment cost will be earmarked as \"assigned\" funds in your Learner Credit budget so you can't overspend."}
               description="A step which explains that the total assignment cost will be earmarked as 'assigned' funds in your Learner Credit budget"
-              values={{
-                doubleQuote: '"',
-              }}
             />
           </li>
           <li>
             <FormattedMessage
               id="lcm.budget.detail.page.catalog.tab.course.card.course.cost.will.convert"
-              defaultMessage="The course cost will automatically convert from {doubleQuote}assigned{doubleQuote} to {doubleQuote}spent{doubleQuote} funds
-                when your learners complete registration."
+              defaultMessage={'The course cost will automatically convert from "assigned" to "spent" funds when your learners complete registration.'}
               description="A step which explains that the course cost will automatically convert from 'assigned' to 'spent' funds when learners complete registration"
-              values={{
-                doubleQuote: '"',
-              }}
             />
           </li>
         </ul>