Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: translate chart hover template and legend #1299

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

muhammad-ammar
Copy link
Contributor

@muhammad-ammar muhammad-ammar commented Sep 12, 2024

Description:

  • Translate hover template for all charts.
  • Translate legend for scatter chart.

JIRA: https://2u-internal.atlassian.net/browse/ENT-9399

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.57%. Comparing base (039039e) to head (566a9e3).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1299   +/-   ##
=======================================
  Coverage   85.57%   85.57%           
=======================================
  Files         567      568    +1     
  Lines       12601    12607    +6     
  Branches     2636     2637    +1     
=======================================
+ Hits        10783    10789    +6     
  Misses       1757     1757           
  Partials       61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muhammad-ammar muhammad-ammar force-pushed the ammar/translate-hovertemplate-and-legends branch 3 times, most recently from 2d883e7 to 2720f0b Compare September 13, 2024 07:21
@muhammad-ammar muhammad-ammar force-pushed the ammar/translate-hovertemplate-and-legends branch from 2720f0b to 2c74155 Compare September 13, 2024 07:34
@muhammad-ammar muhammad-ammar force-pushed the ammar/translate-hovertemplate-and-legends branch from 2c74155 to 1eb92e9 Compare September 19, 2024 07:14
@muhammad-ammar muhammad-ammar force-pushed the ammar/translate-hovertemplate-and-legends branch from 1eb92e9 to 566a9e3 Compare September 19, 2024 07:26
@muhammad-ammar muhammad-ammar merged commit 46203b8 into master Sep 19, 2024
6 checks passed
@muhammad-ammar muhammad-ammar deleted the ammar/translate-hovertemplate-and-legends branch September 19, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants