Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade frontend-lib-content-components version #320

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

alangsto
Copy link
Contributor

Version 1.23.0 of frontent-lib-content-components was causing npm install to fail due to a peer dependency issue with paragon. Version 1.24.0 contains the correct version range for the paragon peer dependency.

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #320 (52e5200) into master (1bd884c) will increase coverage by 0.50%.
The diff coverage is 97.95%.

@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
+ Coverage   73.38%   73.89%   +0.50%     
==========================================
  Files         102      105       +3     
  Lines        1924     1965      +41     
  Branches      455      475      +20     
==========================================
+ Hits         1412     1452      +40     
  Misses        485      485              
- Partials       27       28       +1     
Impacted Files Coverage Δ
src/pages-and-resources/live/messages.js 100.00% <ø> (ø)
src/pages-and-resources/live/data/api.js 92.68% <50.00%> (-2.19%) ⬇️
src/pages-and-resources/live/BBBSettings.jsx 100.00% <100.00%> (ø)
src/pages-and-resources/live/LiveCommonFields.jsx 100.00% <100.00%> (ø)
src/pages-and-resources/live/Settings.jsx 90.00% <100.00%> (+0.25%) ⬆️
src/pages-and-resources/live/ZoomSettings.jsx 100.00% <100.00%> (ø)
src/pages-and-resources/live/constants.js 100.00% <100.00%> (ø)
...-and-resources/live/factories/mockApiResponses.jsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6997b8...52e5200. Read the comment docs.

@alangsto alangsto merged commit 26a7974 into master Jul 12, 2022
@alangsto alangsto deleted the alangsto/update_frontend-lib-content-component branch July 12, 2022 15:14
bradenmacdonald pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Aug 9, 2024
* docs: add adr with test naming conventions

* docs: fix rst

* docs: add further reading section

* Update docs/decisions/0006-test-names.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants