Fixing translations job in this repo #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
==========================================
+ Coverage 73.38% 73.89% +0.50%
==========================================
Files 102 105 +3
Lines 1924 1965 +41
Branches 455 475 +20
==========================================
+ Hits 1412 1452 +40
Misses 485 485
- Partials 27 28 +1
Continue to review full report at Codecov.
|
bradenmacdonald
pushed a commit
to open-craft/frontend-app-authoring
that referenced
this pull request
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a peer dependency issue introduced in new versions of upstream JS libraries which caused these automatic updates to the translations of this repo to fail. Alie's contributed a version bump that avoids that dependency issue, and my commit syncs the lockfile with that version bump so we can hopefully get clean ci.