Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: show Zoom settings when pii sharing is enabled and make launch email optional" #386

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

AhtishamShahid
Copy link
Contributor

@AhtishamShahid AhtishamShahid commented Nov 11, 2022

Reverts #380

Reverting because it was merged mistakenly

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 72.99% // Head: 72.99% // No change to project coverage 👍

Coverage data is based on head (9363f45) compared to base (b8895be).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #386   +/-   ##
=======================================
  Coverage   72.99%   72.99%           
=======================================
  Files         106      106           
  Lines        2037     2037           
  Branches      496      496           
=======================================
  Hits         1487     1487           
  Misses        522      522           
  Partials       28       28           
Impacted Files Coverage Δ
src/pages-and-resources/live/Settings.jsx 90.00% <ø> (ø)
src/pages-and-resources/live/ZoomSettings.jsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AhtishamShahid AhtishamShahid merged commit 3581d63 into master Nov 11, 2022
@AhtishamShahid AhtishamShahid deleted the revert-380-saad/INF-640 branch November 11, 2022 16:25
rpenido pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Jan 2, 2024
…v1.177.1 (openedx#386)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
rpenido pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Jan 2, 2024
Internal issue: https://2u-internal.atlassian.net/servicedesk/customer/portal/9/CR-6328?created=true

Reverted frontend-lib-content-components library updates because:

scroll was not working on editors
potential problems with editor content loading


-----------------------------------------------------------


* Revert "fix(deps): update dependency @edx/frontend-lib-content-components to v1.177.4 (openedx#388)"

This reverts commit d99fa54.

* Revert "fix(deps): update dependency @edx/frontend-lib-content-components to v1.177.1 (openedx#386)"

This reverts commit e14292b.
bradenmacdonald pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Aug 9, 2024
fix: switch to advanced editor for partial credit support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants