Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove default background color for editors #398

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

connorhaugh
Copy link
Contributor

@connorhaugh connorhaugh commented Nov 30, 2022

Completes https://2u-internal.atlassian.net/browse/TNL-10242. Took path of least resistance.

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 72.74% // Head: 72.76% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (3d75f45) compared to base (a7def9c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
+ Coverage   72.74%   72.76%   +0.01%     
==========================================
  Files         106      106              
  Lines        2044     2045       +1     
  Branches      500      501       +1     
==========================================
+ Hits         1487     1488       +1     
  Misses        529      529              
  Partials       28       28              
Impacted Files Coverage Δ
src/CourseAuthoringPage.jsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@KristinAoki KristinAoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We may want to ask Jon if the header and footer should have a drop shadow.

@connorhaugh connorhaugh merged commit 20e9831 into master Dec 2, 2022
@connorhaugh connorhaugh deleted the feat--remove-default-background-color branch December 2, 2022 15:23
rpenido pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Jan 2, 2024
…v1.177.9 (openedx#398)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants