Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force studio url to reload if changed #408

Conversation

ghassanmas
Copy link
Member

Backport of #389

This chagne make it possible if this module was loaded then
the configuration for studio url is changed, then it will pick
the last value.

More context overhangio/tutor-mfe/issues/86

  This chagne make it possible if this module was loaded **then**
  the configuration for studio url is changed, then it will pick
  the last value.

  More context overhangio/tutor-mfe/issues/86
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 11, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @ghassanmas! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@ghassanmas ghassanmas changed the base branch from master to open-release/olive.master December 11, 2022 15:08
@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Base: 74.54% // Head: 72.39% // Decreases project coverage by -2.14% ⚠️

Coverage data is based on head (e63de57) compared to base (f54dc17).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           open-release/olive.master     #408      +/-   ##
=============================================================
- Coverage                      74.54%   72.39%   -2.15%     
=============================================================
  Files                            106      106              
  Lines                           2011     2061      +50     
  Branches                         486      510      +24     
=============================================================
- Hits                            1499     1492       -7     
- Misses                           485      540      +55     
- Partials                          27       29       +2     
Impacted Files Coverage Δ
src/pages-and-resources/data/api.js 46.66% <100.00%> (ø)
...fig-form/apps/shared/InContextDiscussionFields.jsx 36.84% <0.00%> (-63.16%) ⬇️
src/pages-and-resources/proctoring/Settings.jsx 78.75% <0.00%> (-18.85%) ⬇️
...-config-form/apps/shared/DivisionByGroupFields.jsx 54.76% <0.00%> (-11.91%) ⬇️
src/index.jsx 0.00% <0.00%> (ø)
src/CourseAuthoringPage.jsx 100.00% <0.00%> (ø)
src/generic/FormSwitchGroup.jsx 100.00% <0.00%> (ø)
src/pages-and-resources/live/Settings.jsx 90.00% <0.00%> (ø)
src/pages-and-resources/live/BBBSettings.jsx 100.00% <0.00%> (ø)
src/generic/DeletePopup.jsx
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@arbrandes arbrandes merged commit a49bff0 into openedx:open-release/olive.master Dec 12, 2022
@openedx-webhooks
Copy link

@ghassanmas 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

bradenmacdonald pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants