-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: force studio url to reload if changed #408
fix: force studio url to reload if changed #408
Conversation
This chagne make it possible if this module was loaded **then** the configuration for studio url is changed, then it will pick the last value. More context overhangio/tutor-mfe/issues/86
Thanks for the pull request, @ghassanmas! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportBase: 74.54% // Head: 72.39% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## open-release/olive.master #408 +/- ##
=============================================================
- Coverage 74.54% 72.39% -2.15%
=============================================================
Files 106 106
Lines 2011 2061 +50
Branches 486 510 +24
=============================================================
- Hits 1499 1492 -7
- Misses 485 540 +55
- Partials 27 29 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@ghassanmas 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Backport of #389
This chagne make it possible if this module was loaded then
the configuration for studio url is changed, then it will pick
the last value.
More context overhangio/tutor-mfe/issues/86