fix: LTI providers should not be shown unless enabled #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 72.39% // Head: 74.26% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #416 +/- ##
==========================================
+ Coverage 72.39% 74.26% +1.87%
==========================================
Files 106 106
Lines 2061 2067 +6
Branches 510 512 +2
==========================================
+ Hits 1492 1535 +43
+ Misses 540 504 -36
+ Partials 29 28 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
zacharis278
changed the title
MichaelRoytman
approved these changes
Dec 16, 2022
| @@ -463,8 +463,10 @@ describe('ProctoredExamSettings', () => { | |||
| }); | |||
|
|
|||
| it('Does not include lti_external as a selectable option', async () => { | |||
| const courseData = mockGetFutureCourseData; | |||
| courseData.available_proctoring_providers = ['lti_external', 'proctortrack', 'mockproc']; | |||
| const courseData = { | |||
There was a problem hiding this comment.
What was happening here? Was it sharing the same object across tests?
There was a problem hiding this comment.
yeah exactly, this intent was to copy it not modify it.
bradenmacdonald
pushed a commit
to open-craft/frontend-app-authoring
that referenced
this pull request
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MST-1713
Two places because of the old view that should be deprecated in https://2u-internal.atlassian.net/browse/MST-1677