Fixed broken "Pages and Resources" page #446
Conversation
BilalQamar95
changed the title
Codecov ReportBase: 74.45% // Head: 74.48% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #446 +/- ##
==========================================
+ Coverage 74.45% 74.48% +0.02%
==========================================
Files 106 106
Lines 2083 2085 +2
Branches 514 514
==========================================
+ Hits 1551 1553 +2
Misses 504 504
Partials 28 28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
BilalQamar95
changed the title
BilalQamar95
force-pushed
the
bilalqamar95/authoring-page-fix
branch
from
ccb12e1
to
ae91c0b
Compare
|
Tagging in @bszabo to decide whether he wants to field this PR rather than the revert. |
|
I'm working this afternoon to reproduce the error and confirm that this fix makes it go away. This is the preferable way forward if it works. Will report back here. |
src/CourseAuthoringPage.jsx
Outdated
| @@ -57,7 +57,7 @@ const CourseAuthoringPage = ({ courseId, children }) => { | |||
| we shouldn't have the header and footer on these pages. | |||
| This functionality will be removed in TNL-9591 */} | |||
| {inProgress ? !pathname.includes('/editor/') && <Loading /> | |||
| : <AppHeader courseNumber={courseNumber} courseOrg={courseOrg} courseTitle={courseTitle} courseId={courseId} />} | |||
| : AppHeader(courseNumber, courseOrg, courseTitle, courseId)} | |||
There was a problem hiding this comment.
@BilalQamar95 Rendering a React component by calling it as a function instead of rendering it with JSX (i.e., <AppHeader ... />) is an anti-pattern. I would recommend instead changing AppHeader's function signature to make it be a true React component (i.e., accepts a props object that may be destructured), rather than the existing function:
const AppHeader = ({ courseNumber, courseOrg, courseTitle, courseId }) => (...);There was a problem hiding this comment.
Sure, I will update it
|
I've confirmed that this fix resolves the problem for which the |
What has changed
Fixed broken "Pages and Resources" page, as a result of changes made in 322. Updated the AppHeader call in course authoring page.