Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FAL-3375] Feat: Adding video selection gallery page to the routes #461

Merged
merged 2 commits into from
Apr 25, 2023
Merged

[FAL-3375] Feat: Adding video selection gallery page to the routes #461

merged 2 commits into from
Apr 25, 2023

Conversation

ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Mar 15, 2023 •
edited
Loading

Falcon ticket: FAL-3375

Testing instructions

See the testing instructions on: openedx/frontend-lib-content-components#278

Release notes

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 15, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@ChrisChV ChrisChV mentioned this pull request Mar 15, 2023
Merged
1 task
@ChrisChV ChrisChV changed the title Feat: Adding video selection gallery page to the routes [FAL-3375] Feat: Adding video selection gallery page to the routes Mar 15, 2023
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Mar 16, 2023
@giovannicimolin
Copy link

@jristau1984 Just putting this PR on your radar, we'll ask for a review soon.

@e0d
Copy link

e0d commented Mar 21, 2023

@ChrisChV commit lint errors here too.

@codecov
Copy link

codecov bot commented Mar 21, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.34 🎉

Comparison is base (270f4a8) 74.53% compared to head (9532321) 74.88%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #461      +/-   ##
==========================================
+ Coverage   74.53%   74.88%   +0.34%     
==========================================
  Files         108      109       +1     
  Lines        2089     2094       +5     
  Branches      514      516       +2     
==========================================
+ Hits         1557     1568      +11     
+ Misses        504      498       -6     
  Partials       28       28
Impacted Files Coverage Δ
src/CourseAuthoringRoutes.jsx 100.00% <100.00%> (+100.00%) ⬆️
src/selectors/VideoSelectorContainer.jsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChrisChV ChrisChV force-pushed the chris/FAL-3375-video-selection-gallery branch from ffeb1c2 to 70746f1 Compare March 21, 2023 16:03
@ChrisChV
Copy link
Contributor Author

@ChrisChV commit lint errors here too.

@e0d Thanks! Fixed

@giovannicimolin
Copy link

@xitij2000 This is one of the PRs.

@e0d
Copy link

e0d commented Mar 24, 2023

@ChrisChV coverage issues on this PR as well.

@e0d e0d added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Mar 24, 2023
@mphilbrick211 mphilbrick211 removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Mar 24, 2023
@ChrisChV
Copy link
Contributor Author

ChrisChV commented Mar 31, 2023 •
edited
Loading

@e0d I updated the tests here

@ChrisChV ChrisChV force-pushed the chris/FAL-3375-video-selection-gallery branch from fdcfb82 to 9532321 Compare March 31, 2023 18:55
@ChrisChV ChrisChV mentioned this pull request Apr 3, 2023
Closed
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Apr 4, 2023
giovannicimolin
giovannicimolin approved these changes Apr 5, 2023
View reviewed changes
Copy link

@giovannicimolin giovannicimolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Conditionally approved on openedx/frontend-lib-content-components#278 (comment).

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Apr 7, 2023
@mphilbrick211
Copy link

Hi @jristau1984! This is ready for your review/merge. Thanks!

@jristau1984 jristau1984 requested review from kenclary and removed request for jristau1984 April 25, 2023 15:32
kenclary
kenclary approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@kenclary kenclary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kenclary kenclary merged commit 4b7f468 into openedx:master Apr 25, 2023
@openedx-webhooks
Copy link

@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

snglth pushed a commit to Abstract-Tech/community-theme-course-authoring that referenced this pull request Jan 9, 2024
@ChrisChV @snglth
[FAL-3375] Feat: Adding video selection gallery page to the routes (o…
6519ad6 
…penedx#461)

* feat: Adding video selection gallery page to the routes

* test: CourseAuthoringRoutes.test.jsx added
@bradenmacdonald bradenmacdonald deleted the chris/FAL-3375-video-selection-gallery branch July 12, 2024 08:24
bradenmacdonald pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Aug 9, 2024
@jesperhodge
Fix: selectable box in gallery (openedx#461)
fb2a799 
This fixes a bug where images and videos are not clickable when using the Gallery component.
Please see openedx/frontend-lib-content-components#460 for a full description of the bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giovannicimolin giovannicimolin giovannicimolin approved these changes

@kenclary kenclary kenclary approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ChrisChV @openedx-webhooks @giovannicimolin @e0d @mphilbrick211 @kenclary