Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cast progress graph configuration to string #495

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

mariajgrimaldi
Copy link
Member

@mariajgrimaldi mariajgrimaldi commented May 3, 2023

Description

These changes cast the ENABLE_PROGRESS_GRAPH_SETTINGS before comparison. This PR solves: openedx/wg-build-test-release#278 reported while testing the Palm release.

This was the error raised in a local environment:
progress-error-config

Now, after using this change:
progress-fixed
course-authoring-progress

How to test

Using tutor:

  1. Add the following configs to your config.yml
MFE_COURSE_AUTHORING_MFE_APP:
  env:
    production:
      APP_ID: course-authoring
      MFE_CONFIG_API_PATH: http://local.overhang.io/api/mfe_config/v1
  name: course-authoring
  port: 2001
  repository: https://github.com/eduNEXT/frontend-app-course-authoring
  version: MJG/cast-progress-setting
  1. Build the MFE image with these changes
  2. Then run: tutor local start

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 3, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented May 3, 2023

Thanks for the pull request, @mariajgrimaldi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0066902) 74.70% compared to head (ca4bf23) 74.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #495   +/-   ##
=======================================
  Coverage   74.70%   74.70%           
=======================================
  Files         109      109           
  Lines        2107     2107           
  Branches      519      519           
=======================================
  Hits         1574     1574           
  Misses        505      505           
  Partials       28       28           
Impacted Files Coverage Δ
src/pages-and-resources/progress/Settings.jsx 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mariajgrimaldi mariajgrimaldi marked this pull request as ready for review May 10, 2023 13:16
@mphilbrick211
Copy link

Hi @openedx/teaching-and-learning! Would someone be able to approve/merge this?

(context on CodeCov failure)

@mariajgrimaldi
Copy link
Member Author

@jristau1984: thanks for the review! I don't have permissions to merge. Can you give us a hand? Thanks again!

@jristau1984 jristau1984 merged commit 51e5e71 into openedx:master Jun 12, 2023
@openedx-webhooks
Copy link

@mariajgrimaldi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

mariajgrimaldi added a commit to eduNEXT/frontend-app-course-authoring that referenced this pull request Jun 12, 2023
jristau1984 pushed a commit that referenced this pull request Jun 12, 2023
PKulkoRaccoonGang pushed a commit to raccoongang/frontend-app-course-authoring that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants