Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrated backend discussions restriction with UI #507

Merged
merged 4 commits into from
Jun 6, 2023

Conversation

ayesha-waris
Copy link
Contributor

INF-828

Description

Integrated already build UI with the API change in INF-826

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage: 54.76% and project coverage change: +0.01 🎉

Comparison is base (ac7b4c9) 74.82% compared to head (8c9ecb4) 74.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
+ Coverage   74.82%   74.83%   +0.01%     
==========================================
  Files         110      110              
  Lines        2165     2174       +9     
  Branches      555      554       -1     
==========================================
+ Hits         1620     1627       +7     
- Misses        517      519       +2     
  Partials       28       28              
Impacted Files Coverage Δ
src/generic/ConfirmationPopup.jsx 75.00% <0.00%> (ø)
...app-config-form/apps/openedx/OpenedXConfigForm.jsx 84.21% <ø> (ø)
...fig-form/apps/shared/InContextDiscussionFields.jsx 40.00% <ø> (ø)
...-resources/discussions/app-config-form/messages.js 100.00% <ø> (ø)
src/pages-and-resources/discussions/data/slice.js 80.64% <ø> (ø)
...esources/discussions/factories/mockApiResponses.js 100.00% <ø> (ø)
...d/discussion-restrictions/RestrictionSchedules.jsx 50.00% <50.00%> (ø)
src/pages-and-resources/discussions/data/api.js 88.88% <50.00%> (-0.74%) ⬇️
...-config-form/apps/shared/DiscussionRestriction.jsx 66.66% <60.00%> (+16.66%) ⬆️
.../pages-and-resources/discussions/data/constants.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ayesha-waris ayesha-waris requested review from sundasnoreen12 and awais-ansari and removed request for sundasnoreen12 May 31, 2023 17:17
@ayesha-waris ayesha-waris merged commit 1b1afcf into master Jun 6, 2023
@ayesha-waris ayesha-waris deleted the Ayesha/INF-828 branch June 6, 2023 09:55
snglth pushed a commit to Abstract-Tech/community-theme-course-authoring that referenced this pull request Jan 9, 2024
* feat: integrated backend discussions restriction with UI

* refactor: code refactoring

* test: fixes test cases

* refactor: discussion restriction component

---------

Co-authored-by: ayesha waris <[email protected]>
Co-authored-by: Awais Ansari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants