-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrated backend discussions restriction with UI #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayesha-waris
force-pushed
the
Ayesha/INF-828
branch
from
May 31, 2023 16:53
92784eb
to
92c9ac4
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #507 +/- ##
==========================================
+ Coverage 74.82% 74.83% +0.01%
==========================================
Files 110 110
Lines 2165 2174 +9
Branches 555 554 -1
==========================================
+ Hits 1620 1627 +7
- Misses 517 519 +2
Partials 28 28
☔ View full report in Codecov by Sentry. |
ayesha-waris
requested review from
sundasnoreen12 and
awais-ansari
and removed request for
sundasnoreen12
May 31, 2023 17:17
awais-ansari
requested changes
Jun 5, 2023
src/pages-and-resources/discussions/app-config-form/apps/shared/DiscussionRestriction.jsx
Outdated
Show resolved
Hide resolved
src/pages-and-resources/discussions/app-config-form/apps/shared/DiscussionRestriction.jsx
Outdated
Show resolved
Hide resolved
ayesha-waris
force-pushed
the
Ayesha/INF-828
branch
from
June 6, 2023 09:17
77963b9
to
01bb4c8
Compare
awais-ansari
approved these changes
Jun 6, 2023
sundasnoreen12
approved these changes
Jun 6, 2023
snglth
pushed a commit
to Abstract-Tech/community-theme-course-authoring
that referenced
this pull request
Jan 9, 2024
* feat: integrated backend discussions restriction with UI * refactor: code refactoring * test: fixes test cases * refactor: discussion restriction component --------- Co-authored-by: ayesha waris <[email protected]> Co-authored-by: Awais Ansari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INF-828
Description
Integrated already build UI with the API change in INF-826