-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable invalid link Video Uploads #511
fix: disable invalid link Video Uploads #511
Conversation
Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #511 +/- ##
==========================================
+ Coverage 74.83% 75.45% +0.62%
==========================================
Files 110 110
Lines 2174 2176 +2
Branches 554 556 +2
==========================================
+ Hits 1627 1642 +15
+ Misses 519 506 -13
Partials 28 28
☔ View full report in Codecov by Sentry. |
Hi @openedx/teaching-and-learning! This looks ready to review, and merge if all looks good. Thanks! |
@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR is opened to solve the problem with an invalid link to the Video Uploads page. This question has already been asked here.
There are 2 cases:
If the variable
ENABLE_NEW_VIDEO_UPLOAD_PAGE
is set toTrue
, the link "/course/{courseId}/videos" is generated, and the page with the eternal loader is displayed.If the variable
ENABLE_NEW_VIDEO_UPLOAD_PAGE
is set toFalse
, the link "{STUDIO_BASE_URL}/videos/{courseId}" is generated, and a 404 error is returned.I suggest adding the variable
ENABLE_VIDEO_UPLOAD_PAGE_LINK_IN_CONTENT_DROPDOWN
to the .env file in order to control the visibility of this link. Since currently all the links mentioned above are not functional, I recommend setting it toFalse
by default.Result of this fix: