Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable invalid link Video Uploads #511

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

DmytroAlipov
Copy link
Contributor

Description

This PR is opened to solve the problem with an invalid link to the Video Uploads page. This question has already been asked here.

There are 2 cases:

  • If the variable ENABLE_NEW_VIDEO_UPLOAD_PAGE is set to True, the link "/course/{courseId}/videos" is generated, and the page with the eternal loader is displayed.

  • If the variable ENABLE_NEW_VIDEO_UPLOAD_PAGE is set to False, the link "{STUDIO_BASE_URL}/videos/{courseId}" is generated, and a 404 error is returned.

ENABLE_VIDEO_UPLOADS

I suggest adding the variable ENABLE_VIDEO_UPLOAD_PAGE_LINK_IN_CONTENT_DROPDOWN to the .env file in order to control the visibility of this link. Since currently all the links mentioned above are not functional, I recommend setting it to False by default.

Result of this fix:

DISABLE_VIDEO_UPLOADS

@openedx-webhooks
Copy link

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 7, 2023
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.62 🎉

Comparison is base (fac9eab) 74.83% compared to head (e745f9d) 75.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #511      +/-   ##
==========================================
+ Coverage   74.83%   75.45%   +0.62%     
==========================================
  Files         110      110              
  Lines        2174     2176       +2     
  Branches      554      556       +2     
==========================================
+ Hits         1627     1642      +15     
+ Misses        519      506      -13     
  Partials       28       28              
Impacted Files Coverage Δ
src/studio-header/Header.jsx 96.55% <100.00%> (+0.25%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jun 7, 2023
@mphilbrick211 mphilbrick211 requested a review from a team June 7, 2023 23:17
@mphilbrick211
Copy link

Hi @openedx/teaching-and-learning! This looks ready to review, and merge if all looks good. Thanks!

@KristinAoki KristinAoki merged commit e980f1f into openedx:master Jun 8, 2023
@openedx-webhooks
Copy link

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@DmytroAlipov DmytroAlipov deleted the fix-disable-video-uploads branch June 8, 2023 15:13
PKulkoRaccoonGang pushed a commit to raccoongang/frontend-app-course-authoring that referenced this pull request Jun 30, 2023
snglth pushed a commit to Abstract-Tech/community-theme-course-authoring that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants