fix: env custom pages conditional render #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristinAoki
requested review from
kenclary,
jesperhodge,
connorhaugh and
rayzhou-bit
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #525 +/- ##
=======================================
Coverage 77.42% 77.42%
=======================================
Files 120 120
Lines 2352 2352
Branches 568 568
=======================================
Hits 1821 1821
Misses 502 502
Partials 29 29
☔ View full report in Codecov by Sentry. |
KristinAoki
deleted the
KristinAoki/fix-custom-page-misdirect-on-env-variable
branch
PKulkoRaccoonGang
pushed a commit
to raccoongang/frontend-app-course-authoring
that referenced
this pull request
Jun 30, 2023
snglth
pushed a commit
to Abstract-Tech/community-theme-course-authoring
that referenced
this pull request
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditional check for the value of
env.ENABLE_NEW_CUSTOM_PAGESchecked for a boolean value rather than a stringified boolean. This caused the custom pages card on the "Pages & Resources" to always navigate to the MFE page for custom pages regardless of the env variable.To test this, try to navigate to the "Custom pages" page with env variable equal to false. Go to the "Pages & Resources" page and click on the "Custom pages" card. The new page should load the headers, but nothing else. With the variable set to true, navigate back to the "Pages & Resources" page and click on the "Custom pages" card. Now the page should load as expected.