Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add xpert summaries configuration by default for units #567

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

germanolleunlp
Copy link
Contributor

  • Update modals to support reset and delete course xpert summary settings when is disabled
  • Add radio buttons to specify the default value for the xpert course summary settings

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 86.76% and project coverage change: +0.03% 🎉

Comparison is base (530c355) 84.38% compared to head (1e2320c) 84.42%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #567      +/-   ##
==========================================
+ Coverage   84.38%   84.42%   +0.03%     
==========================================
  Files         259      259              
  Lines        4247     4307      +60     
  Branches      959      974      +15     
==========================================
+ Hits         3584     3636      +52     
- Misses        639      647       +8     
  Partials       24       24              
Files Changed Coverage Δ
...es/xpert-unit-summary/XpertUnitSummarySettings.jsx 100.00% <ø> (ø)
...rces/xpert-unit-summary/settings-modal/messages.js 100.00% <ø> (ø)
...es-and-resources/xpert-unit-summary/data/thunks.js 79.66% <73.33%> (-8.22%) ⬇️
...pert-unit-summary/settings-modal/SettingsModal.jsx 86.51% <96.87%> (+6.18%) ⬆️
src/pages-and-resources/data/selectors.js 83.33% <100.00%> (+3.33%) ⬆️
src/pages-and-resources/data/slice.js 52.94% <100.00%> (+6.27%) ⬆️
...pages-and-resources/xpert-unit-summary/data/api.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write more unit tests to cover the cases discovered by codecov that are not yet covered by unit tests?

@germanolleunlp
Copy link
Contributor Author

@schenedx all the lines added have tests for them, I will add some more to increase the coverage for them 🆗

@germanolleunlp
Copy link
Contributor Author

Can you write more unit tests to cover the cases discovered by codecov that are not yet covered by unit tests?

Done ✅

Copy link
Contributor

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@germanolleunlp
Copy link
Contributor Author

germanolleunlp commented Aug 21, 2023

Updated UI: https://jira.2u.com/browse/ACADEMIC-16422
Screen Shot 2023-08-21 at 13 12 44

@germanolleunlp germanolleunlp merged commit fda1208 into master Aug 21, 2023
5 checks passed
@germanolleunlp germanolleunlp deleted the golle/ACADEMIC-16289 branch August 21, 2023 19:14
snglth pushed a commit to Abstract-Tech/community-theme-course-authoring that referenced this pull request Jan 9, 2024
…#567)

* feat: add xpert summaries configuration by default for units
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants