Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add delete confirmation modal #570

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

KristinAoki
Copy link
Member

JIRA Ticket: TNL-10954

When a delete action is called via bulk actions or asset menus, there should be a delete confirmation that appears.

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 84.61% and project coverage change: +2.89% 🎉

Comparison is base (f9bc5c4) 81.53% compared to head (78281ef) 84.42%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
+ Coverage   81.53%   84.42%   +2.89%     
==========================================
  Files         259      259              
  Lines        4245     4309      +64     
  Branches      959      974      +15     
==========================================
+ Hits         3461     3638     +177     
+ Misses        745      647      -98     
+ Partials       39       24      -15     
Files Changed Coverage Δ
src/custom-pages/messages.js 100.00% <ø> (ø)
src/files-and-uploads/ApiStatusToast.jsx 71.42% <0.00%> (ø)
src/files-and-uploads/FileMenu.jsx 66.66% <ø> (ø)
src/files-and-uploads/messages.js 100.00% <ø> (ø)
...rc/files-and-uploads/table-components/ListCard.jsx 78.57% <0.00%> (-1.43%) ⬇️
src/files-and-uploads/FileInput.jsx 100.00% <100.00%> (ø)
src/files-and-uploads/FilesAndUploads.jsx 85.71% <100.00%> (+1.09%) ⬆️
...files-and-uploads/table-components/GalleryCard.jsx 100.00% <100.00%> (ø)
...iles-and-uploads/table-components/TableActions.jsx 83.33% <100.00%> (ø)

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@connorhaugh connorhaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit.

@KristinAoki KristinAoki force-pushed the KristinAoki/fix-file-delete-action-bugs branch from 999d02f to 78281ef Compare August 21, 2023 20:42
@KristinAoki KristinAoki merged commit c1976ce into master Aug 21, 2023
6 checks passed
@KristinAoki KristinAoki deleted the KristinAoki/fix-file-delete-action-bugs branch August 21, 2023 21:28
snglth pushed a commit to Abstract-Tech/community-theme-course-authoring that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants