-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add delete confirmation modal #570
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #570 +/- ##
==========================================
+ Coverage 81.53% 84.42% +2.89%
==========================================
Files 259 259
Lines 4245 4309 +64
Branches 959 974 +15
==========================================
+ Hits 3461 3638 +177
+ Misses 745 647 -98
+ Partials 39 24 -15
☔ View full report in Codecov by Sentry. |
KristinAoki
requested review from
kenclary,
jesperhodge,
connorhaugh and
rayzhou-bit
August 21, 2023 13:31
connorhaugh
reviewed
Aug 21, 2023
connorhaugh
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one nit.
KristinAoki
force-pushed
the
KristinAoki/fix-file-delete-action-bugs
branch
from
August 21, 2023 20:42
999d02f
to
78281ef
Compare
snglth
pushed a commit
to Abstract-Tech/community-theme-course-authoring
that referenced
this pull request
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: TNL-10954
When a delete action is called via bulk actions or asset menus, there should be a delete confirmation that appears.