Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add word break style for long words #574

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

KristinAoki
Copy link
Member

JIRA Ticket: TNL-10959

A temporary fix while Paragon resolves the bug in the component.

Testing

  1. Navigate to the assets page
  2. All cards should have the same length
  3. Open the file info
  4. There should be no horizontal scrolling

@KristinAoki KristinAoki force-pushed the KristinAoki/fix-truncate-line-wrap branch from b9ac9af to 129312c Compare August 21, 2023 19:18
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (b65f4f2) 84.38% compared to head (129312c) 84.42%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #574      +/-   ##
==========================================
+ Coverage   84.38%   84.42%   +0.03%     
==========================================
  Files         259      259              
  Lines        4247     4307      +60     
  Branches      959      974      +15     
==========================================
+ Hits         3584     3636      +52     
- Misses        639      647       +8     
  Partials       24       24              
Files Changed Coverage Δ
src/files-and-uploads/FileInfo.jsx 81.81% <ø> (ø)
...files-and-uploads/table-components/GalleryCard.jsx 100.00% <ø> (ø)
...rc/files-and-uploads/table-components/ListCard.jsx 80.00% <ø> (ø)
src/files-and-uploads/FilesAndUploads.jsx 84.61% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KristinAoki KristinAoki changed the title Kristin aoki/fix truncate line wrap fix: add word break style for long words Aug 21, 2023
Copy link
Contributor

@kenclary kenclary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@KristinAoki KristinAoki merged commit d7a4b5b into master Aug 23, 2023
5 checks passed
@KristinAoki KristinAoki deleted the KristinAoki/fix-truncate-line-wrap branch August 23, 2023 19:17
snglth pushed a commit to Abstract-Tech/community-theme-course-authoring that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants